Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests][dotnet] A few helping touch to do size comparison #11446

Merged
merged 1 commit into from
May 5, 2021

Conversation

spouliot
Copy link
Contributor

@spouliot spouliot commented May 5, 2021

  • Make git ignore the generated report.md
  • Fix .aotdata reported total size in reports (was always 0)
  • Add option to strip the dotnet app bundle (until [1]) so it's easier to compare with oldnet sizes.

[1] #11445

- Make git ignore the generated `report.md`
- Fix `.aotdata` reported total size in reports (was always 0)
- Add option to strip the dotnet app bundle (until [1]) so it's easier to compare with _oldnet_ sizes.

[1] xamarin#11445
@spouliot spouliot requested a review from rolfbjarne as a code owner May 5, 2021 18:06
@spouliot spouliot added the not-notes-worthy Ignore for release notes label May 5, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (no change)

Test results

4 tests failed, 100 tests passed.

Failed tests

  • link all/iOS Unified 64-bits - simulator/Debug [dotnet]: BuildFailure
  • link all/iOS Unified 64-bits - simulator/Release [dotnet]: BuildFailure
  • link all/tvOS - simulator/Debug [dotnet]: BuildFailure
  • link all/tvOS - simulator/Release [dotnet]: BuildFailure

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 7b85076 into 50b68d4

@spouliot
Copy link
Contributor Author

spouliot commented May 5, 2021

Issues are unrelated -> #11456

@spouliot spouliot merged commit 4ba7bf3 into xamarin:main May 5, 2021
@spouliot spouliot deleted the dotnet-size-compare-helper branch May 5, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants