[dotnet] Allow choosing the ICU data file to be used for globalization #11320
Conversation
Defaults to include all globalization data. Depending on the target audience it might be possible to reduce the app size. Draft doc: https://github.com/xamarin/xamarin-macios/wiki/Globalization
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results1 tests failed, 103 tests passed.Failed tests
|
| @@ -143,6 +143,10 @@ | |||
| <UseSystemResourceKeys Condition="'$(UseSystemResourceKeys)' == ''">true</UseSystemResourceKeys> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup> | |||
There was a problem hiding this comment.
I don't think we should have the documentation + logic to select the ICU data. The runtime provides the ICU, so that's also where the other logic should live. That way the logic (and variable name) is shared with Android (and any other products that use the ICU data). We really only need the name of the file to embed in the .app.
There was a problem hiding this comment.
@steveisok any other platform, beside Blazor, using an embedded (not system) ICU like we do ?
There was a problem hiding this comment.
No, only blazor and iOS right now use an embedded icu. I wanted android to also have it, but requiring libc++ wasn't going to work.
I would keep this for now. We can provide props, but unsure exactly when that will come.
There was a problem hiding this comment.
@lewing are you exposing this in any way for blazor ?
If not then I might just stick an underscore to the name and move on... :)
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 108 tests passed 🎉Pipeline on Agent XAMBOT-1101.BigSur |
This was adapted from xamarin#11320.
This was adapted from xamarin#11320.
|
Superceded by #11983 |
Defaults to include all globalization data. Depending on the target
audience it might be possible to reduce the app size.
Draft doc: https://github.com/xamarin/xamarin-macios/wiki/Globalization