-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xcode12.3] [watchOS] Add x86_64 simulator support (#10059) #10196
Conversation
* Bumps mono binaries to include x86_64 watchOS support * Build runtime/registrar x86_64 slices * Produce a 64 bit version of Xamarin.WatchOS.dll * Allow building x86_64 for watch simulators in mtouch * Let xharness know about x86_64 * [tests] Add x86_64 arch to test-libraries * Make dotnet package aware of x64 * [ObjCRuntime] Fix computing if we're calling a stret function or not in a 64-bit watchOS simulator. * [xharness] Re-enable some watchOS tests. Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> New commits in mono/mono: * mono/mono@ac596375c76 Add support for OP_FCONV_TO_I to mini-arm64.c. (xamarin#20548) * mono/mono@392fe5b87b2 [2020-02][watchOS] Add simwatch64 support (xamarin#20552) * mono/mono@a22ed3f094e Fix potential crash for Encoder.Convert (xamarin#20522) * mono/mono@970783731fc Bump to F# 5.0 (xamarin#20511) * mono/mono@32ab5066f72 Bump msbuild to fix a build issue * mono/mono@93a7fe77e8e Ensure special static slots respect alignment. (xamarin#20506) * mono/mono@3db5b358413 [debugger] Switch to GC Unsafe in signal handler callbacks (xamarin#20495) * mono/mono@af315f44c40 [2020-02][corlib] ThreadAbortException protection for ArraySortHelper (xamarin#20468) * mono/mono@ca11fb0fd81 [2020-02] Bump ikvm-fork to include mono/ikvm-fork#20 (xamarin#20452) Diff: https://github.com/mono/mono/compare/be2226b5a1c57df065efc4c1cf008d581e5cec7d..ac596375c762c6b8dbe3c802f0ce626004eab51c
…bit variant of Xamarin.WatchOS.dll. (xamarin#10136) * [src] Don't generate a reference assembly for both the 32-bit and 64-bit variant of Xamarin.WatchOS.dll. We only need one version, and in any case the code would write both the same file, causing corruption and random build problems later. Fixes this problem while building .NET packages: /Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/dotnet/package/common.csproj(75,5): error : Classification matches no files: Xamarin.WatchOS.dll [/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/dotnet/package/Microsoft.watchOS.Ref/package.csproj] make[1]: *** [nupkgs/Microsoft.watchOS.Ref.7.1.100-ci.main.35+sha.a4a1fea86.nupkg] Error 1 * Fix the make rule too so that it doesn't claim it can generate the reference assembly.
Build failure Test results6 tests failed, 131 tests passed.Failed tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get the failing tests ignored as well?
Build failure Test results1 tests failed, 136 tests passed.Failed tests
|
Known failure |
Backport of #10059
Fixes #9949
Bumps mono binaries to include x86_64 watchOS support
Build runtime/registrar x86_64 slices
Produce a 64 bit version of Xamarin.WatchOS.dll
Allow building x86_64 for watch simulators in mtouch
Let xharness know about x86_64
[tests] Add x86_64 arch to test-libraries
Make dotnet package aware of x64
[ObjCRuntime] Fix computing if we're calling a stret function or not in a 64-bit watchOS simulator.
[xharness] Re-enable some watchOS tests.
Co-authored-by: Rolf Bjarne Kvinge rolf@xamarin.com
New commits in mono/mono:
Diff: https://github.com/mono/mono/compare/be2226b5a1c57df065efc4c1cf008d581e5cec7d..ac596375c762c6b8dbe3c802f0ce626004eab51c