[appkit] Fix introspection tests for NSAccessibility on macOS 10.9 #10016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts parts of #9993 and add a special case to the test looking for duplicate attributes between members and the type. Why ? Introspection fails because `bgen` inline the `NSAccessibility` protocol (added in 10.10) into types that existed earlier. That's normally not a problem since the type-level attribute is there. However because of the 10.9 (type) vs 10.10 (protocol) issue that was moved into the manual bindings (so `bgen` does not know it) Even if built inside `COREBUILD` the issue exists since the protocol interface does not really exists at that point (by default), so it's the type (10.9) availability that is looked up. In retrospect we should have created a new type, like Swift did (a few years later), named `NSAccessibilityProtocol` for 10.10. Fix #10009
spouliot
added
run-internal-tests
chamons
approved these changes
Oct 30, 2020
|
Build success |
dalexsoto
approved these changes
Oct 30, 2020
tj-devel709
approved these changes
Oct 30, 2020
whitneyschmidt
approved these changes
Oct 30, 2020
|
Still running - but results on 10.9 are green. |
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.16', Running XM tests on '10.16'' 🔥 ✅ Build succeeded ✅ API Diff (from stable) Test results61 tests failed, 95 tests passed.Failed tests
|
|
Failures are unrelated to PR (it fix the macOS 10.9 failure as expected) and due to #9949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts parts of #9993
and add a special case to the test looking for duplicate attributes
between members and the type.
Why ? Introspection fails because
bgeninline theNSAccessibilityprotocol (added in 10.10) into types that existed earlier. That's
normally not a problem since the type-level attribute is there.
However because of the 10.9 (type) vs 10.10 (protocol) issue that was
moved into the manual bindings (so
bgendoes not know it)Even if built inside
COREBUILDthe issue exists since the protocolinterface does not really exists at that point (by default), so it's
the type (10.9) availability that is looked up.
In retrospect we should have created a new type, like Swift did (a
few years later), named
NSAccessibilityProtocolfor 10.10.Fix #10009