Skip to content

Commit

Permalink
[iAD] Updates for DotNet Attributes (#12495)
Browse files Browse the repository at this point in the history
  • Loading branch information
@tj-devel709
tj-devel709 authored Aug 25, 2021
1 parent 0da207a commit f0373ee
Showing 1 changed file with 30 additions and 0 deletions.
30 changes: 30 additions & 0 deletions src/iAd/ADCompat.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -289,22 +289,50 @@ public virtual void WillLoad(ADBannerView bannerView)
// some of this API is still provided
public partial class ADClient : NSObject {

#if !NET
[Obsoleted (PlatformName.iOS, 15, 0, PlatformArchitecture.None, Constants.iAdRemoved)]
#else
[UnsupportedOSPlatform ("ios15.0")]
#if IOS
[Obsolete ("Starting with ios15.0 The iAd framework has been removed from iOS", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
#endif
#endif
public static NSString? ErrorDomain {
get { return default (NSString); }
}

#if !NET
[Obsoleted (PlatformName.iOS, 15, 0, PlatformArchitecture.None, Constants.iAdRemoved)]
#else
[UnsupportedOSPlatform ("ios15.0")]
#if IOS
[Obsolete ("Starting with ios15.0 The iAd framework has been removed from iOS", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
#endif
#endif
public virtual void DetermineAppInstallationAttribution (AttributedToiAdCompletionHandler completionHandler)
{
}

#if !NET
[Obsoleted (PlatformName.iOS, 15, 0, PlatformArchitecture.None, Constants.iAdRemoved)]
#else
[UnsupportedOSPlatform ("ios15.0")]
#if IOS
[Obsolete ("Starting with ios15.0 The iAd framework has been removed from iOS", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
#endif
#endif
public virtual void LookupAdConversionDetails (ADConversionDetails onCompleted)
{
}

#if !NET
[Obsoleted (PlatformName.iOS, 15, 0, PlatformArchitecture.None, Constants.iAdRemoved)]
#else
[UnsupportedOSPlatform ("ios15.0")]
#if IOS
[Obsolete ("Starting with ios15.0 The iAd framework has been removed from iOS", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
#endif
#endif
public virtual Task<ADClientConversionDetailsResult>? LookupAdConversionDetailsAsync()
{
return default (Task<ADClientConversionDetailsResult>);
Expand Down Expand Up @@ -601,7 +629,9 @@ public static bool ShouldPresentInterstitialAd (this UIViewController This)
#endif
public static class IAdPreroll {

#if !NET
[Introduced (PlatformName.iOS, 8, 0, PlatformArchitecture.All, null)]
#endif
public static void CancelPreroll (this MPMoviePlayerController This)
{
}
Expand Down

3 comments on commit f0373ee

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

✅ API Diff (from PR only) (no change)
✅ Generator Diff (only version changes)

Packages generated

View packages

Test results

49 tests failed, 200 tests passed.

Failed tests

  • introspection/Mac Modern/Debug: BuildFailure
  • introspection/iOS Unified 64-bits - simulator/Debug [dotnet]: Failed
  • introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4) [dotnet]: Failed
  • framework-test/Mac Modern/Debug: BuildFailure
  • framework-test/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • framework-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • framework-test/tvOS - simulator/Debug: BuildFailure
  • framework-test/watchOS 32-bits - simulator/Debug: BuildFailure
  • xcframework-test/Mac Modern/Debug: BuildFailure
  • xcframework-test/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • xcframework-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • xcframework-test/tvOS - simulator/Debug: BuildFailure
  • xcframework-test/watchOS 32-bits - simulator/Debug: BuildFailure
  • xammac tests/Mac Modern/Debug: TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)
  • xammac tests/Mac Modern/Debug (all optimizations): TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)
  • xammac tests/Mac Modern/Release: TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)
  • xammac tests/Mac Modern/Release (all optimizations): TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)
  • monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2469 Passed: 2403 Inconclusive: 13 Failed: 1 Ignored: 65)
  • monotouch-test/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug [dotnet]: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (all optimizations): BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk) [dotnet]: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar) [dotnet]: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations) [dotnet]: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (all optimizations) [dotnet]: BuildFailure
  • monotouch-test/tvOS - simulator/Debug: BuildFailure
  • monotouch-test/tvOS - simulator/Debug [dotnet]: BuildFailure
  • monotouch-test/tvOS - simulator/Debug (LinkSdk): BuildFailure
  • monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure
  • monotouch-test/tvOS - simulator/Debug (all optimizations): BuildFailure
  • monotouch-test/tvOS - simulator/Debug (LinkSdk) [dotnet]: BuildFailure
  • monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: BuildFailure
  • monotouch-test/tvOS - simulator/Release (all optimizations) [dotnet]: BuildFailure
  • monotouch-test/tvOS - simulator/Debug (all optimizations) [dotnet]: BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug: BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug (all optimizations): BuildFailure
  • [xUnit] Mono Mac OS X BCL tests group 4/Mac Modern/Debug: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)
  • mmptest/macOS/Debug: Failed (Execution failed with exit code 1)
  • MSBuild tests/Integration: Failed (Execution failed with exit code 50)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 7)
  • DotNet tests: Failed (Execution failed with exit code 1)

Pipeline on Agent XAMBOT-1025.BigSur'
[iAD] Updates for DotNet Attributes (#12495)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[iAD] Updates for DotNet Attributes (#12495)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[iAD] Updates for DotNet Attributes (#12495)

Please sign in to comment.