-
Notifications
You must be signed in to change notification settings - Fork 516
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FileProvider] Update for Xcode14 binding (#15790)
I introduced a breaking change to the FileProvider Xcode14 binding from adding a new abstract method to the NSFileProviderPendingSetEnumerator protocol. Instead, add this method to be a Xamcore_5_0 addition. PR where issue was introduced found here: #15777 (comment) Co-authored-by: TJ Lambert <tjlambert@microsoft.com> Co-authored-by: Alex Soto <alex@alexsoto.me>
- Loading branch information
1 parent
6b5364f
commit aae74fe
Showing
3 changed files
with
9 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
tests/xtro-sharpie/api-annotations-dotnet/common-FileProvider.ignore
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# New abstract protocol member was added in Xcode14 | ||
# which is a breaking change so adding it to XAMCORE_5_0 | ||
!incorrect-protocol-member! NSFileProviderPendingSetEnumerator::isMaximumSizeReached is REQUIRED and should be abstract |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# New abstract protocol member was added in Xcode14 | ||
# which is a breaking change so adding it to XAMCORE_5_0 | ||
!incorrect-protocol-member! NSFileProviderPendingSetEnumerator::isMaximumSizeReached is REQUIRED and should be abstract |
aae74fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💻 [CI Build] Tests on macOS Mac Catalina (10.15) passed 💻
✅ All tests on macOS Mac Catalina (10.15) passed.
Pipeline on Agent
Hash: aae74febb35d524e68ac63de3ea2dce0126b8a37 [CI build]
aae74fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗ API diff for current PR / commit (Breaking changes)
Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS(no change detected)watchOS(no change detected).NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: (empty diff detected)MacCatalyst: (empty diff detected)✅ API diff vs stable
Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET
ℹ️ Generator diff
Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)
Pipeline on Agent
Hash: aae74febb35d524e68ac63de3ea2dce0126b8a37 [CI build]
aae74fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌
Failed tests are:
Pipeline on Agent
Hash: aae74febb35d524e68ac63de3ea2dce0126b8a37 [CI build]
aae74fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 [CI Build] Artifacts 📚
Packages generated
View packages
Pipeline on Agent XAMMINI-063.Monterey
Hash: aae74febb35d524e68ac63de3ea2dce0126b8a37 [CI build]
aae74fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 [CI Build] Test results 🔥
Test results
❌ Tests failed on VSTS: simulator tests
0 tests crashed, 2 tests failed, 226 tests passed.
Failures
❌ introspection tests
Html Report (VSDrops) Download
❌ monotouch tests
Html Report (VSDrops) Download
Successes
✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download
Pipeline on Agent
Hash: [CI build]