Skip to content

Commit

Permalink
[xharness] Automatically inline Imports to a "shared.csproj" when clo…
Browse files Browse the repository at this point in the history
…ning projects. Fixes #12316 and #12277. (#12322)

This way we process the shared.csproj that we use in our .NET test projects.
The main effect is that we'll clone any project references included in the
shared.csproj, which will fix #12316. On another hand, it means that we'll
add/remove defines in referenced projects, which fixes #12277.

It also allows us to put more code in the "shared.csproj" files.

Fixes #12316.
Fixes #12277.
  • Loading branch information
rolfbjarne authored Aug 4, 2021
1 parent 142e717 commit a91e34f
Show file tree
Hide file tree
Showing 23 changed files with 387 additions and 67 deletions.
32 changes: 32 additions & 0 deletions tests/common/shared-dotnet.csproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- This file is not processed by xharness, and contains logic shared by all our test suites -->
<Project>
<!-- Logic for iOS -->
<PropertyGroup Condition="$(TargetFramework.EndsWith('-ios'))">
<AssetTargetFallback>xamarinios10;$(AssetTargetFallback)</AssetTargetFallback>
</PropertyGroup>
<ItemGroup Condition="'$(_PlatformName)' == 'iOS'">
<PackageReference Include="MonoTouch.Dialog" Version="2.0.0-pre1" />
</ItemGroup>

<!-- Logic for tvOS -->
<PropertyGroup Condition="$(TargetFramework.EndsWith('-tvos'))">
<DefineConstants>$(DefineConstants);XAMCORE_3_0</DefineConstants>
<AssetTargetFallback>xamarintvos10;$(AssetTargetFallback)</AssetTargetFallback>
</PropertyGroup>
<ItemGroup Condition="$(TargetFramework.EndsWith('-tvos'))">
<PackageReference Include="MonoTouch.Dialog" Version="2.0.0-pre1" />
</ItemGroup>

<!-- Logic for macOS -->
<PropertyGroup Condition="$(TargetFramework.EndsWith('-macos'))">
<DefineConstants>$(DefineConstants);MONOMAC</DefineConstants>
</PropertyGroup>

<!-- Logic for Mac Catalyst -->
<PropertyGroup Condition="$(TargetFramework.EndsWith('-maccatalyst'))">
<AssetTargetFallback>xamarinios10;$(AssetTargetFallback)</AssetTargetFallback>
</PropertyGroup>

<!-- Logic for all test suites -->
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-maccatalyst</TargetFramework>
<AssetTargetFallback>xamarinios10;$(AssetTargetFallback)</AssetTargetFallback>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
</PropertyGroup>

<!-- Imports of the form '../shared.csproj' will be inlined by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<!-- this empty item group is here for xharness -->
</ItemGroup>

<Import Project="$(RootTestsDirectory)/linker/ios/dont link/dotnet/shared.csproj" />

</Project>
7 changes: 3 additions & 4 deletions tests/linker/ios/dont link/dotnet/iOS/dont link.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-ios</TargetFramework>
<AssetTargetFallback>xamarinios10;$(AssetTargetFallback)</AssetTargetFallback>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/linker/ios/dont link/dotnet/shared.csproj" />
<!-- Imports of the form '../shared.csproj' will be inlined by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<PackageReference Include="MonoTouch.Dialog" Version="2.0.0-pre1" />
<!-- this empty item group is here for xharness -->
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions tests/linker/ios/dont link/dotnet/shared.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,12 @@
<RootNamespace>dontlink</RootNamespace>
<AssemblyName>dont link</AssemblyName>
<MtouchLink>None</MtouchLink>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildProjectDirectory)\..\..\..'))</RootTestsDirectory>
<ThisTestDirectory>$(RootTestsDirectory)\linker\ios\dont link</ThisTestDirectory>
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/common/shared-dotnet.csproj" />

<ItemGroup>
<PackageReference Include="NUnitLite" Version="3.12.0" />
<ProjectReference Include="$(RootTestsDirectory)\..\external\Touch.Unit\Touch.Client\dotnet\$(_PlatformName)\Touch.Client-$(_PlatformName).dotnet.csproj" />
Expand Down
7 changes: 3 additions & 4 deletions tests/linker/ios/dont link/dotnet/tvOS/dont link.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-tvos</TargetFramework>
<AssetTargetFallback>xamarintvos10;$(AssetTargetFallback)</AssetTargetFallback>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/linker/ios/dont link/dotnet/shared.csproj" />
<!-- Imports of the form '../shared.csproj' will be inlined by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<PackageReference Include="MonoTouch.Dialog" Version="2.0.0-pre1" />
<!-- this empty item group is here for xharness -->
</ItemGroup>
</Project>
7 changes: 3 additions & 4 deletions tests/linker/ios/link all/dotnet/MacCatalyst/link all.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-maccatalyst</TargetFramework>
<AssetTargetFallback>xamarinios10;$(AssetTargetFallback)</AssetTargetFallback>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
</PropertyGroup>

<!-- Imports of the form '../shared.csproj' will be inlined by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<!-- this empty item group is here for xharness -->
</ItemGroup>

<Import Project="$(RootTestsDirectory)/linker/ios/link all/dotnet/shared.csproj" />
</Project>
7 changes: 3 additions & 4 deletions tests/linker/ios/link all/dotnet/iOS/link all.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-ios</TargetFramework>
<AssetTargetFallback>xamarinios10;$(AssetTargetFallback)</AssetTargetFallback>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/linker/ios/link all/dotnet/shared.csproj" />
<!-- Imports of the form '../shared.csproj' will be inlined by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<PackageReference Include="MonoTouch.Dialog" Version="2.0.0-pre1" />
<!-- this empty item group is here for xharness -->
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions tests/linker/ios/link all/dotnet/shared.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@
<MtouchLink>Full</MtouchLink>
<MtouchExtraArgs>--optimize=all,-remove-dynamic-registrar,-force-rejected-types-removal</MtouchExtraArgs>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildProjectDirectory)\..\..\..'))</RootTestsDirectory>
<ThisTestDirectory>$(RootTestsDirectory)\linker\ios\link all</ThisTestDirectory>
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/common/shared-dotnet.csproj" />

<!-- We use configurations like Debug64 and Release64, which doesn't work with the default logic we and .NET have -->
<PropertyGroup Condition="$(Configuration.Contains('Debug'))">
<MtouchDebug>true</MtouchDebug>
Expand Down
8 changes: 3 additions & 5 deletions tests/linker/ios/link all/dotnet/tvOS/link all.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-tvos</TargetFramework>
<DefineConstants>XAMCORE_3_0;$(DefineConstants)</DefineConstants>
<AssetTargetFallback>xamarintvos10;$(AssetTargetFallback)</AssetTargetFallback>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/linker/ios/link all/dotnet/shared.csproj" />
<!-- Imports of the form '../shared.csproj' will be inlined by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<PackageReference Include="MonoTouch.Dialog" Version="2.0.0-pre1" />
<!-- this empty item group is here for xharness -->
</ItemGroup>
</Project>
7 changes: 3 additions & 4 deletions tests/linker/ios/link sdk/dotnet/MacCatalyst/link sdk.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-maccatalyst</TargetFramework>
<AssetTargetFallback>xamarinios10;$(AssetTargetFallback)</AssetTargetFallback>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
</PropertyGroup>

<!-- Imports of the form '../shared.csproj' will be inlined by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<!-- this empty item group is here for xharness -->
</ItemGroup>

<Import Project="$(RootTestsDirectory)/linker/ios/link sdk/dotnet/shared.csproj" />
</Project>
7 changes: 3 additions & 4 deletions tests/linker/ios/link sdk/dotnet/iOS/link sdk.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-ios</TargetFramework>
<AssetTargetFallback>xamarinios10;$(AssetTargetFallback)</AssetTargetFallback>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/linker/ios/link sdk/dotnet/shared.csproj" />
<!-- Imports of the form '../shared.csproj' will be inlined by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<PackageReference Include="MonoTouch.Dialog" Version="2.0.0-pre1" />
<!-- this empty item group is here for xharness -->
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions tests/linker/ios/link sdk/dotnet/shared.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@
<MtouchLink>SdkOnly</MtouchLink>
<MtouchExtraArgs>-disable-thread-check "--dlsym:-link sdk" -gcc_flags="-UhoItsB0rken"</MtouchExtraArgs>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildProjectDirectory)\..\..\..'))</RootTestsDirectory>
<ThisTestDirectory>$(RootTestsDirectory)\linker\ios\link sdk</ThisTestDirectory>
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/common/shared-dotnet.csproj" />

<ItemGroup>
<Reference Include="support">
<HintPath>$(ThisTestDirectory)/support.dll</HintPath>
Expand Down
7 changes: 3 additions & 4 deletions tests/linker/ios/link sdk/dotnet/tvOS/link sdk.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-tvos</TargetFramework>
<AssetTargetFallback>xamarintvos10;$(AssetTargetFallback)</AssetTargetFallback>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/linker/ios/link sdk/dotnet/shared.csproj" />
<!-- Imports of the form '../shared.csproj' will be inlined by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<PackageReference Include="MonoTouch.Dialog" Version="2.0.0-pre1" />
<!-- this empty item group is here for xharness -->
</ItemGroup>
</Project>
10 changes: 4 additions & 6 deletions tests/monotouch-test/dotnet/MacCatalyst/monotouch-test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,16 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-maccatalyst</TargetFramework>
<DefineConstants Condition="'$(Configuration)' == 'Debug'">$(DefineConstants);DYNAMIC_REGISTRAR</DefineConstants> <!-- this can't be in shared.csproj, because xharness needs to remove the DYNAMIC_REGISTRAR define for certain test cases -->
<AssetTargetFallback>xamarinios10;$(AssetTargetFallback)</AssetTargetFallback>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
<AssemblyName>monotouchtest</AssemblyName> <!-- this can't be in shared.csproj, because xharness won't see it there -->
<DefineConstants Condition="'$(Configuration)' == 'Debug'">$(DefineConstants);DYNAMIC_REGISTRAR</DefineConstants>
</PropertyGroup>

<!-- Imports of the form '../shared.csproj' will be inlined by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<!-- this empty item group is here for xharness -->
</ItemGroup>

<Import Project="$(RootTestsDirectory)/monotouch-test/dotnet/shared.csproj" />

<PropertyGroup>
<!-- This must be after the place where xharness injects the RuntimeIdentifier property -->
<DefineConstants Condition="'$(RuntimeIdentifier)' == 'maccatalyst-arm64'">$(DefineConstants);AOT</DefineConstants>
Expand Down
10 changes: 4 additions & 6 deletions tests/monotouch-test/dotnet/iOS/monotouch-test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,13 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-ios</TargetFramework>
<AssetTargetFallback>xamarinios10;$(AssetTargetFallback)</AssetTargetFallback>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
<AssemblyName>monotouchtest</AssemblyName> <!-- this can't be in shared.csproj, because xharness won't see it there -->
<DefineConstants Condition="'$(Platform)' == 'iPhoneSimulator'">$(DefineConstants);DYNAMIC_REGISTRAR</DefineConstants> <!-- this can't be in shared.csproj, because xharness needs to remove the DYNAMIC_REGISTRAR define for certain test cases -->
<DefineConstants Condition="'$(Platform)' == 'iPhoneSimulator'">$(DefineConstants);DYNAMIC_REGISTRAR</DefineConstants>
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/monotouch-test/dotnet/shared.csproj" />
<!-- Imports of the form '../shared.csproj' will be inlined by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<PackageReference Include="MonoTouch.Dialog" Version="2.0.0-pre1" />
<!-- this empty item group is here for xharness -->
</ItemGroup>
</Project>
9 changes: 4 additions & 5 deletions tests/monotouch-test/dotnet/macOS/monotouch-test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-macos</TargetFramework>
<DefineConstants>$(DefineConstants);MONOMAC;XAMMAC_TESTS</DefineConstants>
<DefineConstants Condition="'$(Configuration)' == 'Debug'">$(DefineConstants);DYNAMIC_REGISTRAR</DefineConstants> <!-- this can't be in shared.csproj, because xharness needs to remove the DYNAMIC_REGISTRAR define for certain test cases -->
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
<AssemblyName>monotouchtest</AssemblyName> <!-- this can't be in shared.csproj, because xharness won't see it there -->
<DefineConstants>$(DefineConstants);XAMMAC_TESTS</DefineConstants>
<DefineConstants Condition="'$(Configuration)' == 'Debug'">$(DefineConstants);DYNAMIC_REGISTRAR</DefineConstants>
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/monotouch-test/dotnet/shared.csproj" />
<!-- Imports of the form '../shared.csproj' will be inlined by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<Compile Include="..\..\..\common\Configuration.cs">
Expand Down
4 changes: 4 additions & 0 deletions tests/monotouch-test/dotnet/shared.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
<SignAssembly>True</SignAssembly>
<AssemblyOriginatorKeyFile>..\..\..\..\product.snk</AssemblyOriginatorKeyFile>
<AllowUnsafeBlocks>True</AllowUnsafeBlocks>
<AssemblyName>monotouchtest</AssemblyName>

<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildProjectDirectory)\..\..\..'))</RootTestsDirectory>
<TestLibrariesDirectory>$(RootTestsDirectory)\test-libraries</TestLibrariesDirectory>
<MonoTouchTestDirectory>$(RootTestsDirectory)\monotouch-test</MonoTouchTestDirectory>

Expand All @@ -20,6 +22,8 @@
<DefineConstants Condition="'$(Configuration)' == 'Debug'">$(DefineConstants);DEBUG</DefineConstants>
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/common/shared-dotnet.csproj" />

<ItemGroup>
<PackageReference Include="NUnitLite" Version="3.12.0" />
<ProjectReference Include="$(RootTestsDirectory)\..\external\Touch.Unit\Touch.Client\dotnet\$(_PlatformName)\Touch.Client-$(_PlatformName).dotnet.csproj" />
Expand Down
11 changes: 4 additions & 7 deletions tests/monotouch-test/dotnet/tvOS/monotouch-test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,13 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-tvos</TargetFramework>
<DefineConstants>$(DefineConstants);XAMCORE_3_0</DefineConstants>
<DefineConstants Condition="'$(Platform)' == 'iPhoneSimulator'">$(DefineConstants);DYNAMIC_REGISTRAR</DefineConstants> <!-- this can't be in shared.csproj, because xharness needs to remove the DYNAMIC_REGISTRAR define for certain test cases -->
<AssetTargetFallback>xamarintvos10;$(AssetTargetFallback)</AssetTargetFallback>
<RootTestsDirectory>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)\..\..\..'))</RootTestsDirectory> <!-- this can't be in shared.csproj, because xharness won't see it there -->
<AssemblyName>monotouchtest</AssemblyName> <!-- this can't be in shared.csproj, because xharness won't see it there -->
<DefineConstants Condition="'$(Platform)' == 'iPhoneSimulator'">$(DefineConstants);DYNAMIC_REGISTRAR</DefineConstants>
</PropertyGroup>

<Import Project="$(RootTestsDirectory)/monotouch-test/dotnet/shared.csproj" />
<!-- Imports of the form '../shared.csproj' will be processed by xharness -->
<Import Project="../shared.csproj" />

<ItemGroup>
<PackageReference Include="MonoTouch.Dialog" Version="2.0.0-pre1" />
<!-- this empty item group is here for xharness -->
</ItemGroup>
</Project>
Loading

5 comments on commit a91e34f

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (only version changes)

Packages generated

View packages

Test results

1 tests failed, 224 tests passed.

Failed tests

  • Documentation/All: Failed

Pipeline on Agent XAMBOT-1038.BigSur'
[xharness] Automatically inline Imports to a "shared.csproj" when cloning projects. Fixes #12316 and #12277. (#12322)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[xharness] Automatically inline Imports to a "shared.csproj" when cloning projects. Fixes #12316 and #12277. (#12322)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[xharness] Automatically inline Imports to a "shared.csproj" when cloning projects. Fixes #12316 and #12277. (#12322)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS M1 - Mac Big Sur (11.5) ❌

Tests failed on M1 - Mac Big Sur (11.5).

Failed tests are:

  • xammac_tests

Pipeline on Agent
[xharness] Automatically inline Imports to a "shared.csproj" when cloning projects. Fixes #12316 and #12277. (#12322)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Mojave (10.14) ✅

Tests passed

All tests on macOS X Mac Mojave (10.14) passed.

Pipeline on Agent
[xharness] Automatically inline Imports to a "shared.csproj" when cloning projects. Fixes #12316 and #12277. (#12322)

Please sign in to comment.