[bgen] Add support for converting ObsoletedOSPlatform attributes. Fixes

#18966. (#18972)

Fixes #18966.

src/bgen/AttributeManager.cs

@@ -219,6 +219,8 @@ Type LookupReflectionType (string fullname, ICustomAttributeProvider provider)
 			return typeof (System.Runtime.Versioning.SupportedOSPlatformAttribute);
 		case "System.Runtime.Versioning.UnsupportedOSPlatformAttribute":
 			return typeof (System.Runtime.Versioning.UnsupportedOSPlatformAttribute);
+		case "System.Runtime.Versioning.ObsoletedOSPlatformAttribute":
+			return typeof (System.Runtime.Versioning.ObsoletedOSPlatformAttribute);
 #endif
 		}
 
@@ -338,6 +340,14 @@ Type ConvertTypeToMeta (System.Type type, ICustomAttributeProvider provider)
 				return AttributeFactory.CreateNewAttribute<UnavailableAttribute> (up).Yield ();
 			else
 				return Enumerable.Empty<System.Attribute> ();
+		case "ObsoletedOSPlatformAttribute":
+			var oarg = attribute.ConstructorArguments [0].Value as string;
+			(var op, var ov) = ParseOSPlatformAttribute (oarg);
+			// might have been available for a while...
+			if (ov is null)
+				return AttributeFactory.CreateNewAttribute<ObsoletedAttribute> (op).Yield ();
+			else
+				return AttributeFactory.CreateNewAttribute<ObsoletedAttribute> (op, ov.Major, ov.Minor).Yield ();
 #endif
 		default:
 			return Enumerable.Empty<System.Attribute> ();

tests/bgen/Makefile

@@ -2,4 +2,4 @@ TOP=../..
 include $(TOP)/Make.config
 
 run-tests:
-	$(DOTNET) test
+	$(DOTNET) test $(TEST_FILTER)

tests/common/Configuration.cs

@@ -810,13 +810,18 @@ public static IEnumerable<string> GetBaseLibraryImplementations (ApplePlatform p
 			}
 		}
 
-
 		public static IEnumerable<string> GetRefLibraries ()
 		{
 			foreach (var platform in GetIncludedPlatforms (true))
 				yield return Path.Combine (GetRefDirectory (platform), GetBaseLibraryName (platform, true));
 		}
 
+
+		public static string GetRefLibrary (ApplePlatform platform)
+		{
+			return GetBaseLibrary (platform, true);
+		}
+
 		public static string GetTargetFramework (Profile profile)
 		{
 			switch (profile) {

tests/generator/BGenTests.cs

@@ -1405,6 +1405,21 @@ public void NewerAvailabilityInInlinedProtocol (Profile profile)
 			Assert.That (failures, Is.Empty, "Failures");
 		}
 
+#if !NET
+		[Ignore ("This only applies to .NET")]
+#endif
+		[Test]
+		[TestCase (Profile.iOS)]
+		public void ObsoletedOSPlatform (Profile profile)
+		{
+			Configuration.IgnoreIfIgnoredPlatform (profile.AsPlatform ());
+			var bgen = new BGenTool ();
+			bgen.Profile = profile;
+			bgen.AddTestApiDefinition ("tests/obsoletedosplatform.cs");
+			bgen.CreateTemporaryBinding ();
+			bgen.AssertExecute ("build");
+		}
+
 		BGenTool BuildFile (Profile profile, params string [] filenames)
 		{
 			return BuildFile (profile, true, false, filenames);

tests/generator/tests/obsoletedosplatform.cs

@@ -0,0 +1,10 @@
+using System.Runtime.Versioning;
+using Foundation;
+using UIKit;
+
+namespace iosbindinglib {
+	[Protocol, Model]
+	[BaseType (typeof (UIApplicationDelegate))]
+	public interface TestDelegate {
+	}
+}