Skip to content

Commit

Permalink
[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 (#12038)
Browse files Browse the repository at this point in the history
* [iTunesLibrary] Update bindings for Xcode 13.0 beta 1

* Move existing property back to original location

* Fix message and remove unnecessary Introduced tags

* Fix typo in deprecation message

* Delete empty .todo file
  • Loading branch information
rachelkang authored Jul 9, 2021
1 parent 9d31e45 commit 924c006
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
6 changes: 5 additions & 1 deletion src/iTunesLibrary/Enums.cs
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,14 @@ public enum ITLibPlaylistProperty {
AllItemsPlaylist,
[Field ("ITLibPlaylistPropertyDistinguisedKind")]
DistinguisedKind,
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'Primary' instead.")]
[Field ("ITLibPlaylistPropertyMaster")]
Master,
[Field ("ITLibPlaylistPropertyParentPersistentID")]
ParentPersistentId,
[Mac (12, 0)]
[Field ("ITLibPlaylistPropertyPrimary")]
Primary,
[Field ("ITLibPlaylistPropertyVisible")]
Visible,
[Field ("ITLibPlaylistPropertyItems")]
Expand All @@ -318,4 +322,4 @@ public enum ITLibMediaEntityProperty {
[Field ("ITLibMediaEntityPropertyPersistentID")]
PersistentId,
}
}
}
7 changes: 6 additions & 1 deletion src/ituneslibrary.cs
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,14 @@ interface ITLibPlaylist
[Export ("name")]
string Name { get; }

[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'Primary' instead.")]
[Export ("master")]
bool Master { [Bind ("isMaster")] get; }

[Mac (12,0)]
[Export ("primary")]
bool Primary { [Bind ("isPrimary")] get; }

[NullAllowed, Export ("parentID", ArgumentSemantic.Retain)]
NSNumber ParentId { get; }

Expand Down Expand Up @@ -389,4 +394,4 @@ interface ITLibrary
void UnloadData ();
}

}
}
3 changes: 0 additions & 3 deletions tests/xtro-sharpie/macOS-iTunesLibrary.todo

This file was deleted.

8 comments on commit 924c006

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

Packages generated

View packages

Test results

1 tests failed, 220 tests passed.

Failed tests

  • DotNet tests: Failed (Execution failed with exit code 1)

Pipeline on Agent XAMBOT-1036.BigSur'
[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 (#12038)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS 🔥

Not enough free space in the host.

Pipeline on Agent
[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 (#12038)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 (#12038)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 (#12038)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Catalina (10.15) ✅

Tests passed

All tests on macOS X Mac Catalina (10.15) passed.

Pipeline on Agent
[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 (#12038)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Mojave (10.14) ✅

Tests passed

All tests on macOS X Mac Mojave (10.14) passed.

Pipeline on Agent
[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 (#12038)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac High Sierra (10.13) ✅

Tests passed

All tests on macOS X Mac High Sierra (10.13) passed.

Pipeline on Agent
[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 (#12038)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS32b). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 (#12038)

Please sign in to comment.