Revert "Merge xcode9 into master (#2707)"

This reverts commit 67f4130.

Make.config

@@ -18,7 +18,6 @@ PACKAGE_HEAD_REV=$(shell git rev-parse HEAD)
 # PACKAGE_HEAD_BRANCH (set to the release branch name, this shows up in the IDE's version information, as well as mtouch/mmp --version)
 # IOS_PACKAGE_VERSION (major/minor #)
 # MAC_PACKAGE_VERSION (major/minor #)
-# PACKAGE_VERSION_REV (set to 0 and increment for service releases or previews)
 # (and updating the same on master as well, to next version)
 #
 
@@ -38,23 +37,21 @@ else
 CURRENT_BRANCH:=$(PACKAGE_HEAD_BRANCH)
 endif
 
-# for service releases and previews
-PACKAGE_VERSION_REV=0
-
 IOS_PRODUCT=Xamarin.iOS
 IOS_PACKAGE_NAME=Xamarin.iOS
 IOS_PACKAGE_NAME_LOWER=$(shell echo $(IOS_PACKAGE_NAME) | tr "[:upper:]" "[:lower:]")
 # NEVER customize IOS_PACKAGE_VERSION itself, other parts (mtouch, web updater) are using the IOS_PACKAGE_VERSION_* variables
-IOS_PACKAGE_VERSION=11.3.$(PACKAGE_VERSION_REV).$(IOS_COMMIT_DISTANCE)
+IOS_PACKAGE_VERSION=10.15.0.$(IOS_COMMIT_DISTANCE)
 IOS_PACKAGE_VERSION_MAJOR=$(word 1, $(subst ., ,$(IOS_PACKAGE_VERSION)))
 IOS_PACKAGE_VERSION_MINOR=$(word 2, $(subst ., ,$(IOS_PACKAGE_VERSION)))
-IOS_PACKAGE_VERSION_REV=$(PACKAGE_VERSION_REV)
+IOS_PACKAGE_VERSION_REV=$(word 3, $(subst ., ,$(IOS_PACKAGE_VERSION)))
 IOS_PACKAGE_VERSION_BUILD=$(IOS_COMMIT_DISTANCE)
 IOS_PACKAGE_UPDATE_ID=$(shell printf "2%02d%02d%02d%03d" $(IOS_PACKAGE_VERSION_MAJOR) $(IOS_PACKAGE_VERSION_MINOR) $(IOS_PACKAGE_VERSION_REV) $(IOS_PACKAGE_VERSION_BUILD))
 
-XCODE_VERSION=9
-XCODE_URL=http://xamarin-storage/bot-provisioning/Xcode_9_GM_seed.xip
-XCODE_DEVELOPER_ROOT=/Applications/Xcode9-GM.app/Contents/Developer
+# Xcode 8.3
+XCODE_VERSION=8.3
+XCODE_URL=http://xamarin-storage/bot-provisioning/Xcode_8.3.xip
+XCODE_DEVELOPER_ROOT=/Applications/Xcode83.app/Contents/Developer
 
 # Minimum Mono version
 MIN_MONO_VERSION=5.4.0.60
@@ -75,10 +72,10 @@ MIN_OSX_BUILD_VERSION=10.12
 MIN_OSX_VERSION_FOR_IOS=10.11
 MIN_OSX_VERSION_FOR_MAC=10.11
 
-IOS_SDK_VERSION=11.0
-OSX_SDK_VERSION=10.13
-WATCH_SDK_VERSION=4.0
-TVOS_SDK_VERSION=11.0
+IOS_SDK_VERSION=10.3
+OSX_SDK_VERSION=10.12
+WATCH_SDK_VERSION=3.2
+TVOS_SDK_VERSION=10.2
 
 MIN_IOS_SDK_VERSION=6.0
 MIN_OSX_SDK_VERSION=10.7
@@ -252,10 +249,10 @@ MAC_PRODUCT=Xamarin.Mac
 MAC_PACKAGE_NAME=xamarin.mac
 MAC_PACKAGE_NAME_LOWER=$(shell echo $(MAC_PACKAGE_NAME) | tr "[:upper:]" "[:lower:]")
 
-MAC_PACKAGE_VERSION=4.1.$(PACKAGE_VERSION_REV).$(MAC_COMMIT_DISTANCE)
+MAC_PACKAGE_VERSION=3.9.0.$(MAC_COMMIT_DISTANCE)
 MAC_PACKAGE_VERSION_MAJOR=$(word 1, $(subst ., ,$(MAC_PACKAGE_VERSION)))
 MAC_PACKAGE_VERSION_MINOR=$(word 2, $(subst ., ,$(MAC_PACKAGE_VERSION)))
-MAC_PACKAGE_VERSION_REV=$(PACKAGE_VERSION_REV)
+MAC_PACKAGE_VERSION_REV=$(word 3, $(subst ., ,$(MAC_PACKAGE_VERSION)))
 MAC_PACKAGE_VERSION_BUILD=$(word 4, $(subst ., ,$(MAC_PACKAGE_VERSION)))
 MAC_PACKAGE_VERSION_MAJOR_MINOR=$(MAC_PACKAGE_VERSION_MAJOR).$(MAC_PACKAGE_VERSION_MINOR)
 MAC_PACKAGE_UPDATE_ID=$(shell echo $(subst ., ,$(MAC_PACKAGE_VERSION).$(MAC_PACKAGE_VERSION_BUILD)) | awk '{printf "2%02d%02d%02d%03d",$$1,$$2,$$3,$$4}')

README.md

@@ -142,3 +142,4 @@ We use [Mono's Coding Guidelines](http://www.mono-project.com/community/contribu
 ### Reporting Bugs
 
 We use [Bugzilla](https://bugzilla.xamarin.com/newbug) to track issues.
+

Versions-ios.plist.in

@@ -23,7 +23,6 @@
 			<string>10.1</string>
 			<string>10.2</string>
 			<string>10.3</string>
-			<string>11.0</string>
 		</array>
 		<key>tvOS</key>
 		<array>
@@ -33,7 +32,6 @@
 			<string>10.0</string>
 			<string>10.1</string>
 			<string>10.2</string>
-			<string>11.0</string>
 		</array>
 		<key>watchOS</key>
 		<array>
@@ -44,7 +42,6 @@
 			<string>3.0</string>
 			<string>3.1</string>
 			<string>3.2</string>
-			<string>4.0</string>
 		</array>
 	</dict>
 	<key>RecommendedXcodeVersion</key>

Versions-mac.plist.in

@@ -12,7 +12,6 @@
 			<string>10.10</string>
 			<string>10.11</string>
 			<string>10.12</string>
-			<string>10.13</string>
 		</array>
 	</dict>
 	<key>RecommendedXcodeVersion</key>

builds/Makefile

@@ -805,7 +805,6 @@ SIM_ACVARS = \
 	$(COMMON_ACVARS) \
 	ac_cv_func_clock_nanosleep=no \
 	mono_cv_uscore=yes \
-	ac_cv_func_system=no \
 
 define SimulatorBuildTemplate
 
@@ -1857,15 +1856,13 @@ endif
 
 LLVM_BASE_CONFIGURE_FLAGS=--enable-libcpp --enable-optimized --enable-assertions=no --disable-jit --disable-docs --disable-doxygen
 LLVM_CXXFLAGS=$(CCACHE_CXXFLAGS)
-LLVM_BASE_CONFIGURE_ENVIRONMENT=$(COMMON_ACVARS)
 
 # This is used just for linking with the 32 bit cross compiler
 # FIXME: Avoid building the libs not needed by mono
 .stamp-configure-llvm: $(LLVM_PATH)/configure
 	@mkdir -p llvm/
 	@echo "Configuring llvm"
 	@cd llvm && \
-	$(LLVM_BASE_CONFIGURE_ENVIRONMENT) \
 	$(abspath $(LLVM_PATH)/configure) --prefix=$$PWD/usr --build=i386-apple-darwin10.7  --enable-targets="arm" $(LLVM_BASE_CONFIGURE_FLAGS) --cache-file=../llvm.config.cache CC="$(CCACHE)clang" CXX="$(CCACHE)clang++" CXXFLAGS="$(LLVM_CXXFLAGS)" > $@.log 2>&1 || (echo "Configuring llvm failed:" && cat $@.log | sed "s/^/    /" && exit 1)
 	$(Q) @touch $@
 	@echo Configured llvm
@@ -1874,7 +1871,6 @@ LLVM_BASE_CONFIGURE_ENVIRONMENT=$(COMMON_ACVARS)
 	@mkdir -p llvm64/
 	@echo "Configuring llvm64"
 	@cd llvm64 && \
-	$(LLVM_BASE_CONFIGURE_ENVIRONMENT) \
 	$(abspath $(LLVM_PATH)/configure) --prefix=$$PWD/usr --enable-targets="arm arm64" $(LLVM_BASE_CONFIGURE_FLAGS) --cache-file=../llvm64.config.cache CC="$(CCACHE)clang" CXX="$(CCACHE)clang++" CXXFLAGS="-Qunused-arguments" > $@.log 2>&1 || (echo "Configuring llvm64 failed:" && cat $@.log | sed "s/^/    /" && exit 1)
 	$(Q) @touch $@
 	@echo "Configured llvm64"

docs/website/mtouch-errors.md

@@ -560,21 +560,9 @@ linker. This will most likely result in native linker errors.
 
 The solution is to remove the `--dynamic-symbol-mode=linker` argument from the additional mtouch arguments in the project's Build options.
 
-### <a name="MT0116"/>MT0116: Invalid architecture: {arch}. 32-bit architectures are not supported when deployment target is 11 or later. Make sure the project does not build for a 32-bit architecture.
+### <a name="MT0116"/>MT0116: Aot files could not be found at the expected directory '{msymdir}'.
 
-iOS 11 does not contain support for 32-bit applications, so it's not supported
-to build for a 32-bit application when the deployment target is iOS 11 or
-later.
-
-Either change the target architecture in the project's iOS build options to
-arm64, or change the deployment target in the project's Info.plist to an
-earlier iOS version.
-
-### <a name="MT0117"/>MT0117: Can't launch a 32-bit app on a simulator that only supports 64-bit.
-
-### <a name="MT0118"/>MT0116: Aot files could not be found at the expected directory '{msymdir}'.
-
-<!-- 0119 - 0122: free to use -->
+<!-- 0117 - 0122: free to use -->
 
 ### <a name="MT0123"/>MT0123: The current language was set to '{language}' according to the LANG environment variable (LANG={LANG}).
 

jenkins/nunit-summary.xslt

@@ -0,0 +1,52 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
+<xsl:output indent="no" method='text'/>
+<xsl:strip-space elements="*"/>
+
+<xsl:template match="/">
+	<xsl:apply-templates/>
+</xsl:template>
+
+<xsl:template match="//test-suite[@type='TestFixture']">
+	<xsl:text>&#10;</xsl:text>
+	<xsl:value-of select="@name"/>
+	<xsl:text>&#10;</xsl:text>
+	<xsl:for-each select="current()/results/test-case">
+		<xsl:choose>
+			<xsl:when test="@result='Success'">
+				<xsl:text>    [PASS] </xsl:text>
+			</xsl:when>
+			<xsl:when test="@result='Failure' or @result='Error'">
+				<xsl:text>    [FAIL] </xsl:text>
+			</xsl:when>
+			<xsl:when test="@result='Ignored'">
+				<xsl:text>    [IGNORED] </xsl:text>
+			</xsl:when>
+			<xsl:when test="@result='Inconclusive'">
+				<xsl:text>    [INCONCLUSIVE] </xsl:text>
+			</xsl:when>
+			<xsl:otherwise>
+				<xsl:text>    [INFO] </xsl:text>
+			</xsl:otherwise>
+		</xsl:choose>
+		<xsl:value-of select="../../@name"/><xsl:text>.</xsl:text><xsl:value-of select="@name"/><xsl:if test="failure/message != ''"> : </xsl:if><xsl:value-of select="failure/message"/><xsl:text>&#10;</xsl:text>
+		<xsl:if test="failure/stack-trace != ''">
+			<xsl:value-of select="failure/stack-trace"/>
+			<xsl:text>&#10;</xsl:text>
+		</xsl:if>
+	</xsl:for-each>
+	<xsl:choose>
+		<xsl:when test="@time">
+			<xsl:value-of select="concat(@name,' : ', @time)"/>
+		</xsl:when>
+		<xsl:otherwise>
+			<xsl:value-of select="@name"/>
+		</xsl:otherwise>
+	</xsl:choose>
+	<xsl:text>&#10;</xsl:text>
+</xsl:template>
+<xsl:template match="//test-suite[@type!='TestFixture']/failure/message">
+</xsl:template>
+</xsl:stylesheet>
+
+

mk/xamarin.mk

@@ -1,5 +1,5 @@
 ifdef ENABLE_XAMARIN
-NEEDED_MACCORE_VERSION := e2905474b133977db654cf4036e78616ed92c3bf
+NEEDED_MACCORE_VERSION := 93175c63568e00cf7cf7ac4be5a5cbd4d51bb0b9
 NEEDED_MACCORE_BRANCH := master
 
 MACCORE_DIRECTORY := maccore

msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets

@@ -1856,7 +1856,7 @@ Copyright (C) 2013-2016 Xamarin. All rights reserved.
 		</ItemGroup>
 	</Target>
 
-	<Target Name="_CodesignAppBundle" Condition="('$(_CanOutputAppBundle)' == 'true' And '$(_CodeSigningKey)' != '') And ('$(IsAppExtension)' == 'false' Or '@(_ResolvedAppExtensionReferences)' != '')" DependsOnTargets="$(_CodesignAppBundleDependsOn)"
+	<Target Name="_CodesignAppBundle" Condition="'$(_RequireCodeSigning)' == 'true' And ('$(IsAppExtension)' == 'false' Or '@(_ResolvedAppExtensionReferences)' != '')" DependsOnTargets="$(_CodesignAppBundleDependsOn)"
 		Inputs="@(_CodesignAppBundleInputs)" Outputs="$(_AppBundlePath)_CodeSignature\CodeResources">
 
 		<PropertyGroup>

msbuild/tests/MyPhotoEditingExtension/Info.plist

@@ -18,8 +18,6 @@
 	<string>1.0</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
-	<key>MinimumOSVersion</key>
-	<string>8.0</string>
 	<key>CFBundleVersion</key>
 	<string>1</string>
 	<key>NSExtension</key>

msbuild/tests/MyShareExtension/Info.plist

@@ -18,8 +18,6 @@
 	<string>1.0</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
-	<key>MinimumOSVersion</key>
-	<string>8.0</string>
 	<key>CFBundleVersion</key>
 	<string>1</string>
 	<key>NSExtension</key>

msbuild/tests/MySingleView/Info.plist

@@ -15,7 +15,7 @@
 	<key>UIMainStoryboardFile</key>
 	<string>MainStoryboard</string>
 	<key>MinimumOSVersion</key>
-	<string>7.0</string>
+	<string>6.1</string>
 	<key>CFBundleDisplayName</key>
 	<string>ApplicationName</string>
 	<key>CFBundleIdentifier</key>

msbuild/tests/MyTodayExtension/Info.plist

@@ -18,8 +18,6 @@
 	<string>1.0</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
-	<key>MinimumOSVersion</key>
-	<string>8.0</string>
 	<key>CFBundleVersion</key>
 	<string>1</string>
 	<key>NSExtension</key>

msbuild/tests/Xamarin.iOS.Tasks.Tests/TargetTests/TargetTests.cs

@@ -36,7 +36,6 @@ string[] ExpectedExecutableBundleResources {
 					"LaunchImage-568h@2x.png",
 					"LaunchImage.png",
 					"LaunchImage@2x.png",
-					"Assets.car",
 				};
 				return files.Select (s => Path.Combine (AppBundlePath, s)).ToArray ();
 			}
@@ -436,7 +435,7 @@ public void BundleResources ()
 			var path = Path.Combine (MonoTouchProjectPath, "Info.plist");
 			var plist = PDictionary.FromFile (path);
 
-			plist.SetMinimumOSVersion ("7.0");
+			plist.SetMinimumOSVersion ("6.1");
 			plist.Save (path, true);
 
 			RunTarget (MonoTouchProject, TargetName.CollectBundleResources);
@@ -481,7 +480,7 @@ public void AddAppIcon_NoClean()
 
 			// Start without app icon.
 			plist.Remove("XSAppIconAssets");
-			plist.SetMinimumOSVersion ("7.0");
+			plist.SetMinimumOSVersion ("6.1");
 			plist.Save (path, true);
 
 			RunTarget (project, TargetName.CompileImageAssets);

runtime/Makefile

@@ -41,7 +41,7 @@ Delegates.generated.cs: Delegates.cs.t4 delegates.t4
 	$(Q_GEN) $(TT) $< -o $@
 
 bindings-generator.exe: bindings-generator.cs
-	$(Q) $(SYSTEM_MCS) $< -o:$@ -debug:full
+	$(Q) $(SYSTEM_MCS) $< -o:$@
 
 bindings-generated.m: bindings-generator.exe
 	$(Q_GEN) $(SYSTEM_MONO) --debug $< $@