This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Bump .NET version to 7.0 #807
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,92 +1,32 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFramework>net7.0</TargetFramework> | ||
| <Platform Condition=" '$(Platform)' == '' ">x86</Platform> | ||
| <OutputType>Exe</OutputType> | ||
| <GenerateAssemblyInfo>false</GenerateAssemblyInfo> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|x86' "> | ||
|
There was a problem hiding this comment. These PropertyGroups contain some default settings and duplicate settings, |
||
| <OutputPath>bin\Debug</OutputPath> | ||
| <DefineConstants>DEBUG;</DefineConstants> | ||
| <ExternalConsole>true</ExternalConsole> | ||
| <PlatformTarget>x64</PlatformTarget> | ||
| <LangVersion>latest</LangVersion> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|x86' "> | ||
| <OutputPath>bin\Release</OutputPath> | ||
| <ExternalConsole>true</ExternalConsole> | ||
| <LangVersion>latest</LangVersion> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Include="..\Dynamo\Dynamo.csproj" /> | ||
| <ProjectReference Include="..\SwiftReflector\SwiftReflector.csproj" /> | ||
| <ProjectReference Include="..\SwiftRuntimeLibrary\SwiftRuntimeLibrary.csproj" /> | ||
| <ProjectReference Include="..\tom-swifty\tom-swifty.csproj" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="Mono.Options" Version="6.6.0.161" /> | ||
|
There was a problem hiding this comment. Use Central Package Management to keep all the package versions in sync: https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management There was a problem hiding this comment. Opened an issue for this. |
||
| </ItemGroup> | ||
| <PropertyGroup> | ||
| <LangVersion>latest</LangVersion> | ||
|
There was a problem hiding this comment. This setting is duplicated in the two condition PropertyGroups above, remove the prior ones. |
||
| </PropertyGroup> | ||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,157 +1,20 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFramework>net7.0</TargetFramework> | ||
| <OutputType>Library</OutputType> | ||
| <GenerateAssemblyInfo>false</GenerateAssemblyInfo> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "> | ||
| <OutputPath>bin\Debug</OutputPath> | ||
| <DefineConstants>DEBUG;</DefineConstants> | ||
|
There was a problem hiding this comment. These are default values and can be removed. |
||
| <ConsolePause>false</ConsolePause> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' "> | ||
| <OutputPath>bin\Release</OutputPath> | ||
|
There was a problem hiding this comment. These are default values and can be removed. |
||
| <ConsolePause>false</ConsolePause> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
|
There was a problem hiding this comment. Subfolders are included by default; these can probably be removed. |
||
| <Folder Include="Dynamo.CSLang\" /> | ||
| <Folder Include="Dynamo.SwiftLang\" /> | ||
| </ItemGroup> | ||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,17 @@ | ||
|
|
||
| Microsoft Visual Studio Solution File, Format Version 12.00 | ||
| # Visual Studio 2012 | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Dynamo", "Dynamo.csproj", "{D0E2964B-34C9-4FEE-A638-A10E2E4A0917}" | ||
| EndProject | ||
| Global | ||
| GlobalSection(SolutionConfigurationPlatforms) = preSolution | ||
| Debug|Any CPU = Debug|Any CPU | ||
| Release|Any CPU = Release|Any CPU | ||
| EndGlobalSection | ||
| GlobalSection(ProjectConfigurationPlatforms) = postSolution | ||
| {D0E2964B-34C9-4FEE-A638-A10E2E4A0917}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {D0E2964B-34C9-4FEE-A638-A10E2E4A0917}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {D0E2964B-34C9-4FEE-A638-A10E2E4A0917}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {D0E2964B-34C9-4FEE-A638-A10E2E4A0917}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| EndGlobalSection | ||
| EndGlobal |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the "net7.0" to a variable defined in a root
Directory.Build.propsThen use that variable to set the TargetFramework in every project. i.e:<TargetFramework>$(DOTNET_TFM)</TargetFramework>or
<TargetFramework>$(DOTNET_TFM)-ios</TargetFramework>There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is big enough that I feel it should be its own issue: #809