Fix video recording for non-Oracle JVMs #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non Oracle JDKs do not support writing JPG frames that have alpha channel. See https://bugs.openjdk.java.net/browse/JDK-8211748 for details.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes video recording while running the app in non-Oracle JVMs.
Non-Oracle JVMs do not support writing JPG frames that have an alpha channel. So from now on, we're using PNG frames to record the video that supports alpha (even if we don't have any).
See https://bugs.openjdk.java.net/browse/JDK-8211748 for details.