Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Exclude alternative missing values from horizontal regridding of regrid2 #635

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

lee1043
Copy link
Collaborator

@lee1043 lee1043 commented Apr 4, 2024

Description

Exclude alternative fillValue or missing values (e.g., 1e20) from horizontal regridding process or regrid2, so they won't influence to the regridded field.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@lee1043 lee1043 requested a review from jasonb5 April 4, 2024 00:00
@lee1043 lee1043 self-assigned this Apr 4, 2024
@lee1043 lee1043 marked this pull request as ready for review April 4, 2024 00:01
@lee1043 lee1043 changed the title Exclude alternative missing values from horizontal regridding of regrid2 [PR] Exclude alternative missing values from horizontal regridding of regrid2 Apr 4, 2024
@jasonb5 jasonb5 merged commit 646a9a0 into regrid_nan_update Apr 4, 2024
1 check passed
@jasonb5 jasonb5 deleted the regrid_nan_update_lee1043 branch April 4, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants