-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes handling multiple z axes when vertically regridding #525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jasonb5, here is my code review. I pushed a commit instead of suggesting changes because it was easier to do. Let me know if you agree with my changes.
I'll try to fix the build workflow and merge once the PR is ready.
@tomvothecoder I'm fine with these changes, thanks. |
c73775b
to
e5060fc
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1562 1590 +28
=========================================
+ Hits 1562 1590 +28
☔ View full report in Codecov by Sentry. |
c13afbc
to
d2c2a14
Compare
Thanks @jasonb5. I'm fixing up the build workflow and will merge this PR once I'm done. |
f833460
to
1f6a07f
Compare
- Mamba env update should only skip if cache is not found - Update skip-duplicate-actions to skip entire jobs if true - Add `build-result` job as a workaround to matrix jobs not being considered successful by GitHub if they are skipped which blocks PR merges if those matrix jobs are required
a0e558a
to
52129c9
Compare
Description
ds.regridder.vertical()
breaks withKeyError: 0
ifgrid_positions=None
andinput_grid
has multiple Z axis #519Z
coordinates when using the accessory method.Z
coordinates are present in input grid.build
job not properly updating mamba env if cache not found, causingpytest
to not be found in env #530Checklist
If applicable: