Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix for doc #491

Merged
merged 1 commit into from
May 30, 2023
Merged

Typo fix for doc #491

merged 1 commit into from
May 30, 2023

Conversation

lee1043
Copy link
Collaborator

@lee1043 lee1043 commented May 24, 2023

Description

Typo fix for doc: https://xcdat.readthedocs.io/en/latest/generated/xarray.Dataset.temporal.climatology.html, description for reference_period.

('1850-01-01', 1899-12-31') --> ('1850-01-01', '1899-12-31') (missed single quotation mark in front of 1899 added)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

Typo fix for doc: https://xcdat.readthedocs.io/en/latest/generated/xarray.Dataset.temporal.climatology.html, description for `reference_period`. `('1850-01-01', 1899-12-31')` --> `('1850-01-01', '1899-12-31')`
@github-actions github-actions bot added the type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label May 24, 2023
@lee1043 lee1043 requested a review from tomvothecoder May 24, 2023 19:06
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (0ba0cbd) 100.00% compared to head (dd1ee58) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #491   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1424      1424           
=========================================
  Hits          1424      1424           
Impacted Files Coverage Δ
xcdat/temporal.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tomvothecoder
Copy link
Collaborator

Thanks Jiwoo! Looks good to me.

@lee1043 lee1043 merged commit 2643f7d into main May 30, 2023
@lee1043 lee1043 deleted the lee1043-patch-1 branch May 30, 2023 16:22
@lee1043
Copy link
Collaborator Author

lee1043 commented May 30, 2023

@tomvothecoder thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants