Fix Actor format for 'received grade for' event #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryasmi
reviewed
Oct 5, 2017
There was a problem hiding this comment.
Hey @Nicosoft, thanks for your pull request, it's greatly appreciated! Unfortunately this can't be merged until the Travis build passes. Currently it's failing the tests and I suspect it's because you're calling a method using it's old name. I've made a comment on the code in my review pointing to this 👍
| 'name' => $opts['graded_user_id'], | ||
| ], | ||
| ]; | ||
| $statement['actor'] = $this->readUser($opts, "graded_user"); |
There was a problem hiding this comment.
I think the tests are failing because readUser should be read_user, try changing that @Nicosoft and see if that works.
|
Thanks for fixing the code @Nicosoft, I think this is safe to merge now 👍 |
|
This will appear in the next release which should be v2.1.5, @HT2Bot is making the release via Travis now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
PR Type