Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#130 - Delete records from 'mdl_logstore_xapi_log' after successfully sent them to LRS #131

Merged
merged 4 commits into from
Oct 12, 2017

Conversation

Dasuntha
Copy link
Contributor

Description

  • Delete records from 'mdl_logstore_xapi_log' after successfully sent them to LRS

Related Issues

PR Type

  • Fix or Enhancement

@davidpesce
Copy link
Collaborator

Hi, Dasuntha. Thanks for contributing this! I should be able to test this week.

@bseclier
Copy link

I just test it, it works very well. Thanks @Dasuntha !

@ryasmi ryasmi self-requested a review October 12, 2017 16:25
@ryasmi
Copy link
Member

ryasmi commented Oct 12, 2017

Thanks @bseclier, just waiting for Travis to finish it's build with the recent updates to the master branch in here 👍

@ryasmi ryasmi self-assigned this Oct 12, 2017
@ryasmi ryasmi merged commit 99815cd into xAPI-vle:master Oct 12, 2017
@ryasmi
Copy link
Member

ryasmi commented Oct 12, 2017

@HT2Bot is now creating a new release with this PR via Travis.

@andreasilvestriunitn
Copy link

Hi, we have this problem in 2.2.4 version with Moodle 3.5+ (Build: 20180628) . I think the PR #158 introduced a regression.
I think that in the file store.php the row 158
$k = $xapievents[$key]['context']['extensions'][Event::CONTEXT_EXT_KEY]['id'];
should be
$k = $statements[$key]['context']['extensions'][Event::CONTEXT_EXT_KEY]['id'];
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants