-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made Some relevent changes in the fie system #56
Conversation
Reviewer's Guide by SourceryThis PR significantly enhances the repository's documentation structure by adding detailed README files for various programming language directories and improving the main documentation. The changes include adding comprehensive contribution guidelines, code examples, and setup instructions for each programming language supported in the repository. Class diagram for Java Star class updateclassDiagram
class Star {
+main(String[] args)
}
note for Star "Renamed from 'star' to 'Star'"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @x0lg0n - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please ensure the Java class name 'Star' in Star.java matches the filename. Currently there may be a mismatch between the class name and file name which could cause compilation issues.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
```python | ||
# Program to print Hello World | ||
|
||
print("Hello World!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Standardize 'Hello World' message format
Consider using 'Hello, World!' consistently across all examples in the repository
print("Hello World!") | |
print("Hello, World!") |
|
||
## Files | ||
|
||
- `hello-world.f`: A simple "Hello, World!" program in Fortran. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Update Fortran file extension to modern standard
Modern Fortran programs typically use .f90 or .f95 extensions rather than .f
`hello-world.f90`: A simple "Hello, World!" program in Fortran.
Summary by Sourcery
Enhance documentation by adding detailed contribution guidelines and examples in the main README.md and creating individual README.md files for various programming language directories. Improve Java code by renaming a file and class to adhere to naming conventions.
Enhancements:
Documentation: