added bubblesort

[sanaa-duhh]

Summary by Sourcery

New Features:

• Implement a bubble sort algorithm in C++.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR implements a basic Bubble Sort algorithm in C++. The implementation includes a sorting function, a utility function to print arrays, and a main function demonstrating the usage with a sample array.

Class diagram for Bubble Sort implementation

classDiagram
    class BubbleSort {
        +void bubbleSort(int arr[], int size)
        +void printArray(int arr[], int size)
    }
    class Main {
        +int main()
    }
    BubbleSort <|-- Main : uses

Loading

File-Level Changes

Change	Details	Files
Implementation of Bubble Sort algorithm	Created a bubbleSort function that implements the basic bubble sort algorithm with nested loops Added swap logic using a temporary variable to exchange adjacent elements Implemented size-based iteration to ensure all elements are properly sorted	C++/bubbleSort.cpp
Added utility and demonstration code	Created a printArray function to display array elements Added a main function with a sample array to demonstrate the sorting functionality Included size calculation for the sample array using sizeof	C++/bubbleSort.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @sanaa-duhh - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• The inner loop boundary condition can lead to buffer overflow (link)

Overall Comments:

• There's a buffer overflow vulnerability in bubbleSort() - the inner loop should use size - step - 1 as its bound to avoid accessing beyond array bounds.
• Avoid using <bits/stdc++.h> - it's non-standard and impacts compile times. Instead, include only the specific headers needed (e.g., ).

Here's what I looked at during the review

• 🔴 General issues: 1 blocking issue, 1 other issue
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Avoid using non-standard header <bits/stdc++.h>

This header is compiler-specific and not portable. Use standard headers like instead.

#include <iostream>
#include <algorithm>