Support notification banner content via blocks #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives the user the option between using structured arguments and just passing in text and link information vs providing the heading with a chunk of HTML that will be rendered within the `p.govuk-notification-banner__heading`.
peteryates
referenced
this pull request
Jan 8, 2021
This is a bug and shouldn't have been included. Fixes #88
|
This could possibly be enhanced further with a specific link helper that adds the appropriate classes for notification banner header links. |
peteryates
deleted the
allow-notification-banner-headings-to-take-blocks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives the user the option between using structured arguments and just passing in text and link information vs providing the heading with a chunk of HTML that will be rendered within the
p.govuk-notification-banner__heading.