Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inverted breadcrumbs and back links #429

Merged
merged 2 commits into from
Jul 8, 2023

Conversation

peteryates
Copy link
Member

@peteryates peteryates commented Jun 25, 2023

Support for inverting the colours on back links and breadcrumbs was recently added to govuk-frontend, allowing them to be rendered on darker backgrounds in a legible way. This PR adds support to the relevant components by introducing a inverse keyword argument.

Changes

  • Add support for inverted breadcrumbs
  • Add support for inverted back links

Documentation

Breadcrumbs Back link
Screenshot from 2023-06-25 10-30-05 Screenshot from 2023-06-25 10-31-36

Fixes #428

@peteryates peteryates force-pushed the inverted-breadcrumbs-and-back-links branch from acedb60 to 95dde27 Compare June 25, 2023 09:31
@peteryates
Copy link
Member Author

peteryates commented Jun 25, 2023

Switching organisations made the Netlify integration stop so the doc preview isn't showing. I added screenshots instead. It's fixed now so should work with any subsequent PRs.

@peteryates peteryates force-pushed the inverted-breadcrumbs-and-back-links branch from 95dde27 to dfc06e8 Compare July 8, 2023 21:37
@netlify
Copy link

netlify bot commented Jul 8, 2023

Deploy Preview for govuk-components ready!

Name Link
🔨 Latest commit e2dcddd
🔍 Latest deploy log https://app.netlify.com/sites/govuk-components/deploys/64a9d7d4ecfb1200076cbe2c
😎 Deploy Preview https://deploy-preview-429--govuk-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Support was recently added for inverse breadcrumbs[0]. Like the recent
inverse button change[1] we're using the `inverse` keyword arg to allow
the mode to be toggled.

Refs #428

[0] #418
[1] alphagov/govuk-frontend#3774
Support was recently added for inverse breadcrumbs[0]. Like the recent
inverse button change[1] we're using the `inverse` keyword arg to allow
the mode to be toggled.

Refs #428

[0] #418
[1] alphagov/govuk-frontend#3774
@peteryates peteryates force-pushed the inverted-breadcrumbs-and-back-links branch from dfc06e8 to e2dcddd Compare July 8, 2023 21:40
@peteryates peteryates marked this pull request as ready for review July 8, 2023 21:41
@peteryates peteryates added this pull request to the merge queue Jul 8, 2023
Merged via the queue into main with commit c3ff500 Jul 8, 2023
15 checks passed
@peteryates peteryates deleted the inverted-breadcrumbs-and-back-links branch July 8, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add inverse option to Breadcrumbs and Back link components
1 participant