Add expanded option to accordion slots
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use the Accordion component to replace some long-hand markup in Find Teacher Training (https://github.com/DFE-Digital/find-teacher-training/blob/13f583cb053a5a7687465fccbb66200261b955f4/app/views/result_filters/subject/_form.html.erb#L10) and found that there was no way to specify an initially expanded section (slot). This PR is an attempt to add the option to the Accordion component's Slot sub-component.
I don't think this can be done simply by adding CSS class due the
ariaattribute needed on the heading so I've added an explicitexpandedoption here. There may be a simpler way!One source of confusion (for me) was some JavaScript included in the design system that persists the expanded state of accordions in local storage. So if you've already viewed a page, toggled the expanded state and then revisit it whatever is in local storage overrides whatever the markup specifies.