naprawiony błąd braku zwrotu informacji o walidacji. Dodane logowanie.

wyslijco · Dec 16, 2024 · a98255f · a98255f
1 parent 6adf469
commit a98255f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.github/scripts/process.py b/.github/scripts/process.py
@@ -2,11 +2,10 @@
 import logging
 import os
 
-import yaml
 from github import Auth, Github, Issue
 
 from consts import OrgSchemaIds, NEW_ORG_ISSUE_DEFAULT_TITLE, NEW_ORG_SCHEMA_FILENAME
-from labels import Label, INVALID_FIELD_TO_LABEL
+from labels import Label
 from parsers import FormDataParser
 from pullers import OrgDataPuller
 from utils import has_label
@@ -29,9 +28,11 @@ def process_new_org_issue(issue: Issue, data: FormDataParser):
 
     validator = OrgValidator(data, issue)
     if not validator.validate():
+        logger.error("Validation failed")
         return
 
     if not (org := OrgDataPuller.get_org_by_krs(issue, data.get(OrgSchemaIds.krs))):
+        logger.error("KRS db validation failed")
         return
 
     # Update issue title
@@ -40,6 +41,7 @@ def process_new_org_issue(issue: Issue, data: FormDataParser):
         issue.edit(title=f"{NEW_ORG_ISSUE_DEFAULT_TITLE} {org.name or data.get(OrgSchemaIds.name)}")
 
     if not has_label(issue, Label.AUTO_VERIFIED):
+        logger.info("Adding auto-verified label")
         issue.create_comment(f"@{issue.user.login}, dziękujemy za podanie informacji. "
                              f"Przyjęliśmy zgłoszenie dodania nowej organizacji. "
                              f"Wkrótce skontaktujemy się celem weryfikacji zgłoszenia.")

diff --git a/.github/scripts/validators.py b/.github/scripts/validators.py
@@ -5,7 +5,7 @@
 from github import Issue
 
 from consts import OrgSchemaIds, ORG_SCHEMA_SLUG_FIELD
-from labels import INVALID_FIELD_TO_LABEL, Label
+from labels import INVALID_FIELD_TO_LABEL
 from parsers import FormDataParser
 from utils import has_label
 
@@ -47,7 +47,7 @@ def validate_slug(self) -> tuple[bool, str]:
 
         return True, ""
 
-    def validate(self) -> dict[str, bool]:
+    def validate(self) -> bool:
         """
         Validates the organization data.
 
@@ -78,3 +78,6 @@ def validate(self) -> dict[str, bool]:
             for field, error in errors:
                 msg += f"- **{self.data.get_label(field)}**: {error}\n"
             self.issue.create_comment(msg)
+            return False
+
+        return True