Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复build.md中命令描述错误并补充相关内容 #261

Merged
merged 6 commits into from
Mar 1, 2025

Conversation

sadlavaarsc
Copy link

@sadlavaarsc sadlavaarsc commented Feb 28, 2025

build.md中提示克隆源码后用git submodule --init --recursive同步源码
实际上不能正确同步,完整命令应当是git submodule update --init --recursive

除此以外补充了使用build_command.bat快速编译的指南,方便初学者或者是需要快速编译的开发者比较快捷的获取最新版的静态库。

Summary by CodeRabbit

  • Documentation
    • Updated instructions for synchronizing submodules during setup.
    • Introduced a new "Quick Compilation" section for Windows users, offering step-by-step guidance to compile the code efficiently across multiple supported development environments.

sadlavaarsc and others added 6 commits May 1, 2024 01:42
修复了原本关于依赖库同步的错误,即原本编译指南约第七行提示运行:

git submodule --init --recursive

实际上此命令并不完整,并不会正确同步,因此改为

git submodule update --init --recursive

除此以外还补充了关于build_commands.bat的使用方法,帮助初学者或是刚clone库的开发者比较快捷地完成编译
Copy link

coderabbitai bot commented Feb 28, 2025

Walkthrough

This change updates the instructions in the BUILD.md file. The submodule command has been modified from using git submodule --init --recursive to git submodule update --init --recursive. Additionally, a new section titled "快速编译" (Quick Compilation) has been added to provide guidelines for quickly compiling code on Windows using a batch script. The instructions in this section cover environment checks for MinGW and Visual Studio versions ranging from 2008 to 2022. No modifications were made to any exported or public entities.

Changes

File(s) Change Summary
BUILD.md Updated submodule command; added "快速编译" section with instructions for quick Windows compilation using build_commands.bat supporting MinGW and multiple Visual Studio versions

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant B as build_commands.bat
    participant E as Compiler Environment
    U->>B: Run build_commands.bat
    B->>E: Check for MinGW/Visual Studio configuration
    E-->>B: Return environment status
    B->>E: Trigger compilation process
    E-->>B: Compile code and output to build folder
    B->>U: Notify completion
Loading

Poem

Hoppity-hop, I skip along,
In a code garden where changes belong.
New commands spring with a rhythmic beat,
Quick compile magic makes my journey sweet.
With batch scripts guiding my playful quest,
I nibble bugs and cheer at our build’s success!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
BUILD.md (1)

25-44: Well-structured "快速编译" section addition.
This new section clearly explains how to quickly compile the code on Windows using a batch script. The instructions are detailed and list supported environments (MinGW, various Visual Studio versions), which is very helpful for beginners.

A couple of minor points for refinement:

  • Script Filename Consistency: The text refers to the batch file as build_commands.bat while earlier indications mentioned build_command.bat. Please confirm that the filename is consistent with the actual file in the repository.
  • Markdown List Indentation: The unordered list items on lines 33–41 are indented with a single space. Markdown lint (MD007) expects the list markers to start at the beginning of the line. Consider removing the extra space to adhere to conventional Markdown formatting. For example:
-  - MinGW
-  - Visual Studio 2008
-  - Visual Studio 2010
-  - Visual Studio 2012
-  - Visual Studio 2013
-  - Visual Studio 2015
-  - Visual Studio 2017
-  - Visual Studio 2019
-  - Visual Studio 2022
+ - MinGW
+ - Visual Studio 2008
+ - Visual Studio 2010
+ - Visual Studio 2012
+ - Visual Studio 2013
+ - Visual Studio 2015
+ - Visual Studio 2017
+ - Visual Studio 2019
+ - Visual Studio 2022

Otherwise, the additional details and instructions are clear and beneficial.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

33-33: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


34-34: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


35-35: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


36-36: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


37-37: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


38-38: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


39-39: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


40-40: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


41-41: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2d667b and 2a72b14.

📒 Files selected for processing (1)
  • BUILD.md (2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
BUILD.md

33-33: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


34-34: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


35-35: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


36-36: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


37-37: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


38-38: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


39-39: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


40-40: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


41-41: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)

🔇 Additional comments (1)
BUILD.md (1)

7-7: Correct Git submodule command update.
The command has been correctly updated to
git submodule update --init --recursive
which ensures that the submodules are properly synchronized after cloning.

@chirsz-ever chirsz-ever merged commit 84e4cc5 into wysaid:master Mar 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants