adjust: 纠正 PIMAGE 和 PCIMAGE 的错误混用

[yixy-only]

Summary by CodeRabbit

• New Features

  • Introduced a new drawing control that lets you adjust line widths for enhanced visual customization.

• Refactor

  • Refined graphics operations—including drawing styles and text measurements—ensuring more consistent and reliable rendering.
  • Streamlined image handling across visual and typography functions for improved performance and overall user experience.

[coderabbitai]

Walkthrough

This pull request modifies several function signatures across header and source files to update the image parameter types for improved const-correctness and clarity. A new function setlinewidth has been added, and existing functions such as setlinestyle, getlinecap, getlinejoin, textwidth, and textheight have their image pointer types adjusted. Additionally, in the implementation file, image conversion macros have been updated, and corresponding drawing functions now use a mutable image pointer where necessary.

Changes

File(s)	Change Summary
include/ege.h	Added new function setlinewidth(float width, PIMAGE pimg = NULL). Updated signatures for setlinestyle (minor formatting), getlinecap, getlinejoin, textwidth, and textheight to use PCIMAGE for image parameters.
src/egegapi.cpp	Replaced CONVERT_IMAGE_CONST with CONVERT_IMAGE in several functions. Updated signatures for setlinecolor, setfillcolor, setbkmode, getlinecap, getlinejoin, and ege_puttexture to use PIMAGE instead of PCIMAGE.
src/font.cpp	Modified signatures of textwidth, textheight, settextjustify, setfont, and getfont to change image parameter types from PIMAGE to PCIMAGE, and updated related macros accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant App as Application
    participant EGE as Graphics Engine

    App->>EGE: setlinewidth(width, pimg?)
    EGE-->>App: Update line width in drawing context

Loading

Possibly related PRs

• chore: 消除部分编译器警告 #258: Updates function signatures for line cap and join operations by modifying image pointer types.
• adjust: 将ege_前缀的文本输出函数的坐标参数类型由 int 改为 float #259: Alters image parameter types in header functions related to text and coordinate handling.

Poem

In a burrow of code, I joyfully roam,
Adjusting line widths to make graphics my home.
With pointers now clear, constant and true,
Each function sings in hues anew.
Hoppy cheers from this rabbit so bright,
Coding in leaps by day and by night! 🐰

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7abf8f and 2dde695.

📒 Files selected for processing (3)

• include/ege.h (2 hunks)
• src/egegapi.cpp (28 hunks)
• src/font.cpp (6 hunks)

🧰 Additional context used

🪛 Cppcheck (2.10-2)

src/font.cpp

[error] 377-377: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)

🔇 Additional comments (8)

src/font.cpp (2)

253-313: LGTM! Improved const-correctness in text measurement functions.

The change from PIMAGE to PCIMAGE for textwidth and textheight functions is correct since these functions only need read-only access to the image data. This improves type safety by preventing accidental modifications to the image.

🧰 Tools

🪛 Cppcheck (2.10-2)

[error] 311-311: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)

---

[error] 312-312: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)

---

[error] 313-313: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)

---

574-592: LGTM! Improved const-correctness in font management functions.

The change from PIMAGE to PCIMAGE for getfont functions is correct since these functions only need read-only access to the image data. This improves type safety by preventing accidental modifications to the image.

include/ege.h (3)

934-934: LGTM! Added setlinewidth function.

The new setlinewidth function follows the same pattern as other line style functions and provides a way to set the line width for drawing operations.

---

941-947: LGTM! Improved const-correctness in line style getter functions.

The change from PIMAGE to PCIMAGE for getlinecap and getlinejoin functions is correct since these functions only need read-only access to the image data. This improves type safety by preventing accidental modifications to the image.

---

1255-1263: LGTM! Improved const-correctness in text measurement function declarations.

The change from PIMAGE to PCIMAGE for textwidth and textheight function declarations matches their implementations in font.cpp and correctly indicates that these functions only need read-only access to the image data.

src/egegapi.cpp (3)

65-65: LGTM! Correct macro usage for mutable image access.

The change from CONVERT_IMAGE_CONST to CONVERT_IMAGE is appropriate since setwritemode modifies the image state by calling SetROP2.

---

1339-1409: LGTM! Improved const-correctness in getter functions.

The changes to use PCIMAGE instead of PIMAGE in the getter functions getlinecap and getlinejoin improve const-correctness since these functions only read from the image state and don't modify it.

---

1276-1287: LGTM! Well-implemented new function.

The new setlinewidth function:

• Correctly uses CONVERT_IMAGE for mutable access
• Updates both thickness and linewidth properties
• Follows the pattern of other setter functions by calling update_pen

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.