-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sp to sf #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'update-sp-to-sf' of https://github.com/tfullman/BaBA into update-sp-to-sf # Conflicts: # R/BaBA.R
@tfullman, thanks for all the work on updating the BaBA package. I am going to go ahead and accept your pull request. So I am changing version to 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
BaBA
code from reliance onsp
,rgdal
, andrgeos
to use of sf to resolve #3This includes multiple updates to code in the
BaBA
andBaRanking
functions, package data, documentation and descriptions as follows:Update
BaBA
codesf
instead ofsp
,raster
, andrgeos
strtns
function to not useadehabitatLT
movement.segment.b
to usesf
instead ofsp
spatial data formatsstr_mean
andstr_sd
to classification output for clearer understanding of behavior assignmentsBaRanking
Update
BaRanking
codesf
NA
for all fence segments withtotal_enc < min_total_enc
, rather than excluding these segments. This retains data on total encounters and number of individuals interacting with fences that may be of interest to users while still retaining the sample size constraints on the permeability index calculation. This seems in keeping with the description of the function in the help file.Other changes
sf
formatDESCRIPTION
andNAMESPACE
for consistency with the changes made aboveI checked all the results of the updated functions against those from the original functions and all match exactly.
A package check with
devtools::check()
flagged missing documentation for the package data. Perhaps @wx-ecology could add this? The “Document your data” section of https://grasshoppermouse.github.io/posts/2017-10-18-put-your-data-in-an-r-package/ provides an example.If these updates are accepted it would probably be good to also update the package version. Perhaps to 2.0, since this is a major switch in the underlying code, data format, and approach?
Thank you for all your great work creating this package!