sql (fix): Quote digit QName parts to generate valid SQL #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takezoe
commented
Apr 20, 2024
| @@ -463,9 +463,6 @@ object Expression { | |||
| QuotedIdentifier(x.stripPrefix("\"").stripSuffix("\""), None) | |||
| } else if (x.matches("[0-9]+")) { | |||
| DigitId(x, None) | |||
| } else if (!x.matches("[0-9a-zA-Z_]*")) { | |||
| // Quotations are needed with special characters to generate valid SQL | |||
| QuotedIdentifier(x, None) | |||
There was a problem hiding this comment.
Moved to QName.sqlExpr so that this method can focus on identifier generation without handling special cases.
takezoe
force-pushed
the
sql-quote-qname-parts
branch
from
738b632 to
00f66ca
Compare
takezoe
changed the title
|
Ok. Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.