Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http (feature): Accept concrete filter instances in RxRouter.fitler/andThen #3334

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

xerial
Copy link
Member

@xerial xerial commented Jan 10, 2024

  • finagle: Deprecate Finagle.server
  • http (feature): Support concrete filter/endpoint instance
  • Support Scala 2

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a0b5fea) 82.58% compared to head (e19c955) 82.53%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3334      +/-   ##
==========================================
- Coverage   82.58%   82.53%   -0.06%     
==========================================
  Files         355      355              
  Lines       14853    14855       +2     
  Branches     2463     2470       +7     
==========================================
- Hits        12267    12260       -7     
- Misses       2586     2595       +9     
Files Coverage Δ
...in/scala/wvlet/airframe/http/finagle/Finagle.scala 100.00% <ø> (ø)
...vm/src/main/scala/wvlet/airframe/http/Router.scala 90.47% <100.00%> (-0.66%) ⬇️
.../main/scala/wvlet/airframe/http/RxHttpFilter.scala 72.72% <ø> (ø)
.../src/main/scala/wvlet/airframe/http/RxRouter.scala 43.58% <100.00%> (+1.48%) ⬆️
.../scala/wvlet/airframe/http/filter/CorsFilter.scala 86.48% <ø> (+8.10%) ⬆️
...t/airframe/http/router/HttpRequestDispatcher.scala 89.18% <85.71%> (-0.29%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0b5fea...e19c955. Read the comment docs.

@xerial xerial changed the title netty (feature): Support concrete filter/endpoint instances in RxRouter http (feature): Accept concrete filter instances in RxRouter.fitler/andThen Jan 11, 2024
@xerial xerial merged commit 02a0e94 into main Jan 11, 2024
17 checks passed
@xerial xerial deleted the deprecate-finagle branch January 11, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant