Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Introduce scalafix #3328

Merged
merged 1 commit into from
Jan 9, 2024
Merged

internal: Introduce scalafix #3328

merged 1 commit into from
Jan 9, 2024

Conversation

xerial
Copy link
Member

@xerial xerial commented Jan 9, 2024

Testing scalafix.

Due to scala2/3 compatibilities, we cannot enable some common rules, but at least scalacenter/scalafix#542 worked

@github-actions github-actions bot added bug internal Internal changes (usually non-user facing) labels Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f40ab0) 82.60% compared to head (309e6d4) 82.60%.
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3328   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files         355      355           
  Lines       14854    14861    +7     
  Branches     2497     2537   +40     
=======================================
+ Hits        12270    12276    +6     
- Misses       2584     2585    +1     
Files Coverage Δ
...ame-di/src/main/scala/wvlet/airframe/Session.scala 86.95% <ø> (ø)
...rame/http/codegen/client/HttpClientGenerator.scala 100.00% <ø> (ø)
...n/scala/wvlet/airframe/http/grpc/GrpcContext.scala 100.00% <ø> (ø)
...rframe/http/grpc/internal/GrpcServiceBuilder.scala 95.45% <ø> (ø)
...n/src/main/scala/wvlet/airframe/json/package.scala 59.09% <ø> (ø)
...-rx/src/main/scala/wvlet/airframe/rx/package.scala 100.00% <ø> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f40ab0...309e6d4. Read the comment docs.

@xerial xerial removed the bug label Jan 9, 2024
@xerial xerial merged commit 9fbb607 into main Jan 9, 2024
17 checks passed
@xerial xerial deleted the scala-fix branch January 9, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes (usually non-user facing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant