airframe-sql: Fix SQL generation for JOIN #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takezoe
commented
Feb 10, 2023
| SQLAnalyzer.analyze("select * from (select * from A) inner join A using (id)", "default", demoCatalog) | ||
|
|
||
| val sql = SQLGenerator.print(resolvedPlan).toLowerCase | ||
| sql shouldBe "select * from (select * from a) join a using (id)" |
There was a problem hiding this comment.
Without this fix, the following invalid SQL is generated:
select * from select * from a join a using (id)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2748 +/- ##
==========================================
+ Coverage 82.27% 82.29% +0.01%
==========================================
Files 337 337
Lines 14143 14142 -1
Branches 2218 2250 +32
==========================================
+ Hits 11636 11638 +2
+ Misses 2507 2504 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLGeneratorgenerates invalid SQL if left side of JOIN is sub-query.