Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-sql: Preserve GroupingKey indexes #2716

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Conversation

xerial
Copy link
Member

@xerial xerial commented Jan 24, 2023

No description provided.

@xerial xerial added kaizen code improvement without changing user-facing functionality internal Internal changes (usually non-user facing) and removed kaizen code improvement without changing user-facing functionality labels Jan 24, 2023
@xerial xerial requested a review from takezoe January 24, 2023 02:11
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #2716 (8bdd1fe) into master (7df0115) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8bdd1fe differs from pull request most recent head eeedbe6. Consider uploading reports for the commit eeedbe6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2716      +/-   ##
==========================================
- Coverage   82.19%   82.18%   -0.01%     
==========================================
  Files         337      337              
  Lines       14111    14115       +4     
  Branches     2235     2255      +20     
==========================================
+ Hits        11598    11601       +3     
- Misses       2513     2514       +1     
Impacted Files Coverage Δ
.../scala/wvlet/airframe/sql/model/ResolvedPlan.scala 63.63% <ø> (ø)
...ala/wvlet/airframe/sql/analyzer/TypeResolver.scala 93.08% <100.00%> (+0.67%) ⬆️
...in/scala/wvlet/airframe/sql/model/Expression.scala 72.39% <100.00%> (+0.37%) ⬆️
...scala/wvlet/airframe/sql/parser/SQLGenerator.scala 91.15% <100.00%> (ø)
...ala/wvlet/airframe/sql/parser/SQLInterpreter.scala 89.80% <100.00%> (ø)
...frame-rx/src/main/scala/wvlet/airframe/rx/Rx.scala 83.95% <0.00%> (-1.24%) ⬇️
...rx/src/main/scala/wvlet/airframe/rx/RxRunner.scala 94.88% <0.00%> (-0.40%) ⬇️
...me-log/src/main/scala/wvlet/log/io/StopWatch.scala 80.85% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e721ee...eeedbe6. Read the comment docs.

@xerial xerial merged commit 5799add into master Jan 24, 2023
@xerial xerial deleted the resolve-group-by-index branch January 24, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes (usually non-user facing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants