This repository has been archived by the owner on May 13, 2019. It is now read-only.
break waiting for claiming partition if new consumer join #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're experiencing the same issue, and the PR proposed here fixes it (thank you, @mrcold !) |
wvanbergen
approved these changes
Dec 3, 2017
|
Thanks! |
quipo
added a commit
to MeltwaterArchive/kafka-cg
that referenced
this pull request
Dec 4, 2017
…consumer join) + add more logging
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PR #101 , I still run into some issues. When a consumer is looping 62s for the previous partition owner to release it, some new consumer may join, so the all of the assignment will be calculated again.
In this case, it make no sense to waiting for the partition calculated based-on the old consumer list. It should break the waiting loop and trying to claim all of the new assigned partitions.