Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pvacsplice #170

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add pvacsplice #170

wants to merge 13 commits into from

Conversation

mhoang22
Copy link

No description provided.

@mhoang22 mhoang22 marked this pull request as ready for review January 21, 2025 21:32
definitions/immuno.wdl Outdated Show resolved Hide resolved
@mhoang22
Copy link
Author

mhoang22 commented Jan 21, 2025

the immuno.wdl included in this PR currently doesnt have 'biotypes' and 'aggregate_inclusion_count_limit' since I expect those to be added under pvacseq input in another PR ( #168: https://github.com/wustl-oncology/analysis-wdls/pull/168/files#diff-ed70ea67da14854bdf95f53076b4a4b92111eb531717823eafd5fe7c54271796 )

Follow up: I have added biotypes and aggregate_inclusion_count_limit in immuno wdl input under pvacseq. Note that these 2 inputs are not added to subworkflows and tools pvacseq.wdl yet.

@@ -0,0 +1,60 @@
version 1.0

task regtools {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since regtools is a whole suite of tools, we might want to give this task and file a more specific name in case other parts of it need to be added to workflows in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure if in the future we plan to integrate more tools beyond regtools for the task of identifying and quantifying reads supporting splicing junctions, thus im naming the tast regtools at the moment. But else, would 'IdentifySpliceVariantJunction' be a good name for the task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants