escape HTML entities in code parsed from markdown, fixes hakimel#2744

wusongbuaa · Sep 9, 2020 · e09437f · e09437f
1 parent 676936e
commit e09437f
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/plugin/markdown/markdown.esm.js b/plugin/markdown/markdown.esm.js
diff --git a/plugin/markdown/markdown.js b/plugin/markdown/markdown.js
diff --git a/plugin/markdown/plugin.js b/plugin/markdown/plugin.js
@@ -15,6 +15,14 @@ const SCRIPT_END_PLACEHOLDER = '__SCRIPT_END__';
 
 const CODE_LINE_NUMBER_REGEX = /\[([\s\d,|-]*)\]/;
 
+const HTML_ESCAPE_MAP = {
+  '&': '&amp;',
+  '<': '&lt;',
+  '>': '&gt;',
+  '"': '&quot;',
+  "'": '&#39;'
+};
+
 const Plugin = () => {
 
 	// The reveal.js instance this plugin is attached to
@@ -399,6 +407,12 @@ const Plugin = () => {
 
 	}
 
+	function escapeForHTML( input ) {
+
+	  return input.replace( /([&<>'"])/g, char => HTML_ESCAPE_MAP[char] );
+
+	}
+
 	return {
 		id: 'markdown',
 
@@ -427,6 +441,11 @@ const Plugin = () => {
 					language = language.replace( CODE_LINE_NUMBER_REGEX, '' ).trim();
 				}
 
+				// Escape before this gets injected into the DOM to
+				// avoid having the HTML parser alter our code before
+				// highlight.js is able to read it
+				code = escapeForHTML( code );
+
 				return `<pre><code ${lineNumbers} class="${language}">${code}</code></pre>`;
 			};