Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade go to 1.23 #1473

Merged
merged 19 commits into from
Dec 20, 2024
Merged

feat: upgrade go to 1.23 #1473

merged 19 commits into from
Dec 20, 2024

Conversation

StarpTech
Copy link
Contributor

Motivation and Context

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-34e7b3cf93e3050e3c426bfb66b3fb0bc3db0d99

@StarpTech StarpTech changed the title chore: upgrade go to 1.23 feat: upgrade go to 1.23 Dec 20, 2024
@StarpTech StarpTech marked this pull request as ready for review December 20, 2024 16:00
Noroth
Noroth approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@Noroth Noroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some nits. Your call

.github/actions/build-push-image/action.yaml Outdated Show resolved Hide resolved
.github/workflows/router-ci.yaml Outdated Show resolved Hide resolved
connect-go/go.sum Show resolved Hide resolved
@StarpTech @Noroth
Update .github/actions/build-push-image/action.yaml
cb34b37 
Co-authored-by: Ludwig <ludwig.bedacht@gmail.com>
@StarpTech StarpTech merged commit 4c29d2d into main Dec 20, 2024
17 checks passed
@StarpTech StarpTech deleted the dustin/upgrade-go branch December 20, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noroth Noroth Noroth approved these changes

@devsergiy devsergiy Awaiting requested review from devsergiy

@jensneuse jensneuse Awaiting requested review from jensneuse

@df-wg df-wg Awaiting requested review from df-wg

Assignees
No one assigned
Labels
aws-lambda-router graphqlmetrics monorepo router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StarpTech @Noroth