Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report error on fallback certificate load failure #7

Closed
hvge opened this issue Oct 4, 2019 · 0 comments
Closed

Report error on fallback certificate load failure #7

hvge opened this issue Oct 4, 2019 · 0 comments
Assignees
@hvge

Comments

@hvge
Copy link
Member

hvge commented Oct 4, 2019 •
edited
Loading

Currently, CertStore's internal loadFallbackCertificates() function silently ignores decoding error when JSON data is processed. Due to data format change introduced in PR #6, we should no longer ignore such error.

EDIT: It's better handle this in CertStoreConfiguration.validate() function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvge hvge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hvge