Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Electron v12, allow packaging as arm64 for macOS #1051

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

codetheweb
Copy link
Contributor

Closes #970.

To my knowledge, the only binary now that does not support arm64 is gifsicle. I opened a PR, up to you if you want to wait for that to merge this.

- Bumped Electron to v12
- Also bumped node-aperture for the arm64 slice
@sindresorhus
Copy link
Contributor

Thanks for working on this. Make sure you have thoroughly tested that nothing broke in the Electron update.

@codetheweb
Copy link
Contributor Author

Everything seems to be working fine so far in my testing (changing preferences, encoding to different formats, using plugins, etc.).

Looks like the PR on gifsicle was merged but hasn't been released yet.

@sindresorhus sindresorhus merged commit 47b36c8 into wulkano:main Nov 23, 2021
@sindresorhus
Copy link
Contributor

We cannot upgrade to the latest version of gifsicle-bin as it requires ESM, which Electron do not support. However, gifsicle-bin just fetches the binary from the repo, which is now updated, so in theory, we should not need to do anything.

@codetheweb
Copy link
Contributor Author

Makes sense. Thank you!

I would update https://kap-latest-release.now.sh/api but it doesn't look like the source for that route is public.

@atticoos
Copy link

atticoos commented Jul 6, 2022

Heads up -- the community is experiencing a big impact on performance somewhere around the time of this patch, described here #1125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native Apple Silicon support
3 participants