Feature/widget validation #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 29, 2019 13:00
goeson00
requested changes
Nov 4, 2019
| const validationSchema = createWidgetValidationSchema(values.type, generalFields, constraints) | ||
| setValidationSchema(validationSchema) | ||
| // eslint-disable-next-line | ||
| }, [values.type]) |
There was a problem hiding this comment.
Add all dependencies, react will handle which will be updated - values.type in this case anyway, because rest are the same :)
cogboard-webapp/src/components/widgets/dialogFields/MultilineTextInput.js
Outdated
Show resolved
Hide resolved
cogboard-webapp/src/components/widgets/dialogFields/SonarQubeMetricsInput.js
Outdated
Show resolved
Hide resolved
cogboard-webapp/src/components/widgets/dialogFields/TextInput.js
Outdated
Show resolved
Hide resolved
cogboard-webapp/src/hooks/index.js
Outdated
| validationSchema.validate(values, {abortEarly: false}) | ||
| .then(value => func(value)) | ||
| validationSchema.validate(values, {abortEarly: false, stripUnknown: true}) | ||
| .then(value => { |
added 2 commits
November 7, 2019 13:16
…get-validation # Conflicts: # cogboard-webapp/src/components/BoardForm/index.js # cogboard-webapp/src/components/DropdownField.js # cogboard-webapp/src/components/WidgetForm/helpers.js # cogboard-webapp/src/components/WidgetForm/index.js # cogboard-webapp/src/components/WidgetTypeForm/helpers.js # cogboard-webapp/src/components/widgets/dialogFields/AemHealthcheckInput.js # cogboard-webapp/src/components/widgets/dialogFields/SonarQubeMetricsInput.js # cogboard-webapp/src/components/widgets/dialogFields/index.js # cogboard-webapp/src/components/widgets/index.js # cogboard-webapp/src/constants/index.js # cogboard-webapp/src/helpers/index.js # cogboard-webapp/src/hooks/index.js
goeson00
requested changes
Nov 11, 2019
| @@ -13,7 +13,9 @@ const conditionallyHidden = (Component, conditionField, condition) => ({values, | |||
| } | |||
|
|
|||
| conditionallyHidden.propTypes = { | |||
| component: node | |||
| Component: node, | |||
There was a problem hiding this comment.
Please change it to elementType.
added 2 commits
November 12, 2019 08:28
…get-validation # Conflicts: # cogboard-webapp/src/components/AddWidget.js # cogboard-webapp/src/components/BoardForm/index.js # cogboard-webapp/src/components/BoardForm/styled.js # cogboard-webapp/src/components/BoardForm/validators.js # cogboard-webapp/src/components/EditBoard.js # cogboard-webapp/src/components/EditWidget.js # cogboard-webapp/src/components/ValidationMessages.js # cogboard-webapp/src/components/WidgetForm/helpers.js # cogboard-webapp/src/components/WidgetForm/index.js # cogboard-webapp/src/components/WidgetForm/styled.js # cogboard-webapp/src/components/WidgetTypeForm/helpers.js # cogboard-webapp/src/components/WidgetTypeForm/index.js # cogboard-webapp/src/components/widgets/dialogFields/AemHealthcheckInput.js # cogboard-webapp/src/components/widgets/dialogFields/CheckboxInput.js # cogboard-webapp/src/components/widgets/dialogFields/NumberInput.js # cogboard-webapp/src/components/widgets/dialogFields/SonarQubeMetricsInput.js # cogboard-webapp/src/components/widgets/dialogFields/index.js # cogboard-webapp/src/components/widgets/index.js # cogboard-webapp/src/helpers/index.js # cogboard-webapp/src/hooks/index.js
goeson00
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know in the comments about validation rules for the widget's fields.