-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix widget columns configuration #79
Fix widget columns configuration #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes for consistency.
@@ -8,10 +8,11 @@ import { useFormData } from '../../hooks'; | |||
import { getBoards } from '../../selectors'; | |||
import { createValidationSchema } from './validators'; | |||
import { trimLeadingZeros } from '../helpers'; | |||
import NumberInput from "../widgets/dialogFields/NumberInput"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add empty line between components and other imports. Components should be imported as the last ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -90,7 +90,7 @@ const WidgetForm = ({ renderActions, ...initialFormValues }) => { | |||
shrink: true | |||
}} | |||
inputProps={{ | |||
min: ROWS_MIN, | |||
min: WIDGET_ROWS_MIN, | |||
max: 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have constant for min, we should have for max if it is not dynamic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Fix widget columns configuration; change TextField to NumberField component