Feature/update world clock widget #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michalskrzypek
commented
Sep 13, 2019
michalskrzypek
commented
- added new date formats,
- separated date formats from time formats,
- added differentation between 24- and 12-hour clock
- changed datetime display in widget,
- added option to enable/disable display of date and time,
- moved constants and helpers related to WC widget to the adequate file.
michalskrzypek
requested review from
szymon-owczarzak,
goeson00,
yahorm and
marcin-witaszek-wttech
goeson00
requested changes
Sep 16, 2019
| @@ -40,3 +12,7 @@ export const sortByKey = (obj, key, asc = true) => Object.entries(obj) | |||
|
|
|||
| return newObj; | |||
| }, {}); | |||
|
|
|||
| Array.prototype.insert = function ( index, item ) { | |||
There was a problem hiding this comment.
Adding methods to build in objects prototypes is considered a bad idea. These are reserved for internal language features. Please create an util function.
| const date = getDateTime(timeZoneId, dateFormat); | ||
|
|
||
| const initTime = getDateTime(timeZoneId, timeFormat); | ||
| let [time, setTime] = useState(initTime); |
There was a problem hiding this comment.
Use const here, you won't reassign these values i suppose.
| @@ -1,24 +1,41 @@ | |||
| import React, {useState} from 'react'; | |||
| import Typography from "@material-ui/core/Typography/index"; | |||
| import {string} from "prop-types"; | |||
| import {Typography} from "@material-ui/core"; | |||
There was a problem hiding this comment.
Move to components imports. I remind that you have 3 types of imports in the following order: libs, internal helpers/actions/hooks, components: 3rd party/own.
goeson00
approved these changes
Sep 16, 2019
szymon-owczarzak
approved these changes
Sep 16, 2019
Cich0sza
pushed a commit
that referenced
this pull request
Sep 23, 2019
Feature/update world clock widget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.