Add advanced board switcher functionality #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymon-owczarzak
suggested changes
Sep 12, 2019
| @@ -51,6 +52,19 @@ const BoardForm = ({ renderActions, ...initialFormValues }) => { | |||
| label="Auto switch" | |||
| /> | |||
| </FormControl> | |||
| {autoSwitch && | |||
| <TextField | |||
| onChange={handleChange('switchInterval')} | |||
There was a problem hiding this comment.
If invoking handleChange on initial render is not intentional, you can use two different ways of binding parameter:
() => handleChange('switchInterval')handleChange.bind(this, 'switchInterval')
There was a problem hiding this comment.
Bind is definitely slower than arrow, but it is intentional, check the implementation of handler and you will notice a function returning a function.
| @@ -0,0 +1,15 @@ | |||
| export const formatTime = (timeInSec) => { | |||
There was a problem hiding this comment.
Parenthesis are not necessary here, but it is convention. Decided style can be included in prettier config in the future
| [isPlaying, timeElapsed, switchInterval, switchBoard] | ||
| ); | ||
|
|
||
| return { handleBoardsSwitch, handlePlayToggle, timeElapsed, switchInterval, isPlaying, prevBoardTitle, nextBoardTitle }; |
There was a problem hiding this comment.
Personally I would put here each prop in separate line, but it's also convention and configurable by prettier
marcin-witaszek-wttech
approved these changes
Sep 12, 2019
szymon-owczarzak
approved these changes
Sep 17, 2019
Cich0sza
pushed a commit
that referenced
this pull request
Sep 23, 2019
…ting Add advanced board switcher functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.