#346 | Refresh every APP state after save event #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 29, 2021 13:41
szymon-owczarzak
added
the
not ready
4 tasks
Comment on lines
+335
to
+338
| CONFIG_LOADED: () => ({ | ||
| type: 'info', | ||
| message: 'Config Loaded', | ||
| duration: 3000 |
There was a problem hiding this comment.
Cogboard will now display a message each time a new config is loaded in the background.
Comment on lines
-132
to
-134
| export const saveDataStart = () => ({ | ||
| type: SAVE_DATA_START | ||
| }); |
| dispatch(saveDataSuccess()); | ||
| dispatch(refetchInitData()); |
There was a problem hiding this comment.
on SAVE event success - fetch config again
szymon-owczarzak
changed the title
Comment on lines
-9
to
-15
| const val STATUS_CODE_401 = 401 | ||
| const val STATUS_CODE_200 = 200 | ||
| const val PROP_ID = "id" | ||
| const val PROP_EVENT_TYPE = "eventType" | ||
| const val PROP_BOARDS = "boards" | ||
| const val PROP_BOARDS_BY_ID = "boardsById" | ||
| const val PROP_BOARDS_ALL = "allBoards" |
There was a problem hiding this comment.
Moved to separate objects...
szymon-owczarzak
removed
the
not ready
devzbysiu
previously approved these changes
Apr 1, 2021
yahorm
reviewed
Apr 1, 2021
| @@ -9,26 +11,23 @@ import io.vertx.core.logging.LoggerFactory | |||
| class ConfirmationSender(private val vertx: Vertx) { | |||
|
|
|||
| fun sendOk() { | |||
| vertx.eventBus().send(CogboardConstants.EVENT_SEND_MESSAGE_TO_WEBSOCKET, | |||
| JsonObject().message(OK_MESSAGE)) | |||
| vertx.eventBus().send(Event.SEND_MESSAGE_TO_WEBSOCKET, JsonObject().message(OK_MESSAGE)) | |||
| } | |||
|
|
|||
| fun sendError(body: JsonObject) { | |||
There was a problem hiding this comment.
Is this method used somewhere?
There was a problem hiding this comment.
No it is not i will delete
yahorm
previously approved these changes
Apr 1, 2021
There was a problem hiding this comment.
great job @szymon-owczarzak! the constants have become more readable :)
szymon-owczarzak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More details in related issue: #346
Types of changes
Checklist:
I hereby agree to the terms of the Cogboard Contributor License Agreement.