Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/add update date #33

Merged
merged 9 commits into from
Sep 4, 2019
Merged

Conversation

michalskrzypek
Copy link
Contributor

No description provided.

@@ -0,0 +1,12 @@
import React from 'react';

const LastUpdateField = (props) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract props in function arguments.

cogboard-webapp/src/components/LastUpdateField.js Outdated Show resolved Hide resolved
cogboard-webapp/src/components/LastUpdateField.js Outdated Show resolved Hide resolved
@@ -103,6 +105,8 @@ const Widget = ({ id, index }) => {
closeMenu();
};

let showUpdateTime = widgetTypes[type] ? widgetTypes[type].showUpdateTime : false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to const.

@szymon-owczarzak szymon-owczarzak merged commit 281b357 into master Sep 4, 2019
@szymon-owczarzak szymon-owczarzak deleted the features/add-update-date branch September 6, 2019 14:29
Cich0sza pushed a commit that referenced this pull request Sep 23, 2019
* Generate update time on front-end

* Add update time checker

* Revert LOAD_DATA const

* Style fixes

* Revert LOAD_DATA const

* Jenkins, SonarQube, Bamboo Plan, Service Check widgets will also present update time

* IFrame will now expand to 100% available height.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants