Sonarqube Widget - token authentication support #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymon-owczarzak
suggested changes
Oct 21, 2020
There was a problem hiding this comment.
- Look at my comments
- Extend AsyncWidget with the method
authenticationTypeswhich returnssetOf(AuthType.BASIC)by default and can be overwritten in specific widgets. The order in the set will be used by HttpClient to guess wich authType to use first - if config does not math this auth type (for example token is not set) then next will be used.
cogboard-app/src/main/kotlin/com/cognifide/cogboard/http/HttpClient.kt
Outdated
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/http/HttpClient.kt
Outdated
Show resolved
Hide resolved
szymon-owczarzak
changed the title
cogboard-app/src/main/kotlin/com/cognifide/cogboard/http/HttpClient.kt
Outdated
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/http/HttpClient.kt
Outdated
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/widget/AsyncWidget.kt
Outdated
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/widget/type/AemBundleInfoWidget.kt
Outdated
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/widget/type/AemHealthcheckWidget.kt
Outdated
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/widget/type/BambooDeploymentWidget.kt
Outdated
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/widget/type/BambooPlanWidget.kt
Outdated
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/widget/type/JiraBucketsWidget.kt
Outdated
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/widget/AsyncWidget.kt
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/widget/AsyncWidget.kt
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/widget/type/ServiceCheckWidget.kt
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/widget/type/AemBundleInfoWidget.kt
Outdated
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/widget/type/AemHealthcheckWidget.kt
Outdated
Show resolved
Hide resolved
szymon-owczarzak
previously approved these changes
Oct 22, 2020
cogboard-app/src/main/kotlin/com/cognifide/cogboard/http/auth/AuthenticationType.kt
Show resolved
Hide resolved
…onal fields, fix cypress tests
YellowFlash525
approved these changes
Oct 23, 2020
szymon-owczarzak
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.