-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation/reorder widgets reworking #253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymon-owczarzak
suggested changes
Feb 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @mpiotrowski1 !
Two things that need improvement:
- Please split dashboard and widget reordering tests into 2 files:
dashboards_reordering.js
andwidgets_reordering.js
- Make sure that dashboards are deleted after successful tests - AFAIS there are some leftovers after tests passed.
…, respectively) and added removing the boards after the test is done to dashboards' tests.
….com/Cognifide/cogboard into automation/reorder-widgets-reworking
Re: 1. Done, though I named the files "reordering_widgets.js" and "reordering_dashboards.js" respectively, so that they are grouped together, when listed alphabetically. |
mpiotrowski1
requested review from
szymon-owczarzak
and removed request for
staszke
February 18, 2020 12:25
szymon-owczarzak
approved these changes
Feb 19, 2020
szymon-owczarzak
added
the
maintenance
documentation, refactoring, releasing etc...
label
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I rewrote the Cypress automatic tests for reordering the widgets on board (both when logged in & logged out), because they needed a specific state of application to work. Now the test creates its own board state before testing the functonality.
I also moved that into one test, as good part of it is setting up the enviroment, and the test for reordering when logged out would only differ by a few lines (logging out itself, and the assertions) - with testing when logged in first, as it's more important, and if it doesn't work, it's likely the other part wouldn't work, either.
Motivation and Context
It removes the need to have a specific state of board/application for the automatic test to work.
Checklist:
I hereby agree to the terms of the Cogboard Contributor License Agreement.