Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation/reorder widgets reworking #253

Merged
merged 6 commits into from
Feb 19, 2020

Conversation

mpiotrowski1
Copy link
Collaborator

Description

I rewrote the Cypress automatic tests for reordering the widgets on board (both when logged in & logged out), because they needed a specific state of application to work. Now the test creates its own board state before testing the functonality.

I also moved that into one test, as good part of it is setting up the enviroment, and the test for reordering when logged out would only differ by a few lines (logging out itself, and the assertions) - with testing when logged in first, as it's more important, and if it doesn't work, it's likely the other part wouldn't work, either.

Motivation and Context

It removes the need to have a specific state of board/application for the automatic test to work.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Automated functional tests have been added or modified to cover my changes (if applicable)
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Cogboard Contributor License Agreement.

Copy link
Contributor

@szymon-owczarzak szymon-owczarzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mpiotrowski1 !
Two things that need improvement:

  1. Please split dashboard and widget reordering tests into 2 files:
    dashboards_reordering.js and widgets_reordering.js
  2. Make sure that dashboards are deleted after successful tests - AFAIS there are some leftovers after tests passed.

…, respectively) and added removing the boards after the test is done to dashboards' tests.
@mpiotrowski1
Copy link
Collaborator Author

Two things that need improvement:

  1. Please split dashboard and widget reordering tests into 2 files:
    dashboards_reordering.js and widgets_reordering.js
  2. Make sure that dashboards are deleted after successful tests - AFAIS there are some leftovers after tests passed.

Re: 1. Done, though I named the files "reordering_widgets.js" and "reordering_dashboards.js" respectively, so that they are grouped together, when listed alphabetically.
Re: 2. Done.

@mpiotrowski1 mpiotrowski1 requested review from szymon-owczarzak and removed request for staszke February 18, 2020 12:25
@mpiotrowski1 mpiotrowski1 merged commit e4cf851 into master Feb 19, 2020
@mpiotrowski1 mpiotrowski1 deleted the automation/reorder-widgets-reworking branch February 19, 2020 11:07
@szymon-owczarzak szymon-owczarzak added the maintenance documentation, refactoring, releasing etc... label Feb 21, 2020
@mpiotrowski1 mpiotrowski1 restored the automation/reorder-widgets-reworking branch March 2, 2020 12:54
@mpiotrowski1 mpiotrowski1 deleted the automation/reorder-widgets-reworking branch March 2, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance documentation, refactoring, releasing etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants