Prettier plugin added to Cypress tests #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymon-owczarzak
added
the
maintenance
Comment on lines
+1
to
+3
| { | ||
| "singleQuote": true | ||
| } |
There was a problem hiding this comment.
Prettier setup
Comment on lines
+85
to
+86
| `createWidget(name)` - use any name from `functional/cypress-tests/cypress/fixtures/Widgets.js` for example: `Widgets.whiteSpace.name` - this will add configured widget to current board. Widget type will be deducted from name prop. | ||
|
|
There was a problem hiding this comment.
Documentation update
Comment on lines
+10
to
+38
| "eslint-config-prettier": "^6.9.0", | ||
| "eslint-plugin-cypress": "^2.8.1", | ||
| "eslint-plugin-prettier": "^3.1.2", | ||
| "husky": "^4.0.6", | ||
| "lint-staged": "^9.5.0", | ||
| "prettier": "^1.19.1", | ||
| "pretty-quick": "^2.0.1" | ||
| }, | ||
| "scripts": { | ||
| "test": "npm install & npx cypress run --browser chrome" | ||
| "test": "npm install & npx cypress run --browser chrome", | ||
| "prettier": "prettier --write \"cypress/**/*.{js,ts,json}\"" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/Cognifide/cogboard" | ||
| }, | ||
| "author": "", | ||
| "license": "ISC" | ||
| "license": "ISC", | ||
| "husky": { | ||
| "hooks": { | ||
| "pre-commit": "lint-staged" | ||
| } | ||
| }, | ||
| "lint-staged": { | ||
| "cypress/**/*.{js,ts,json}": [ | ||
| "pretty-quick --staged", | ||
| "git add" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Prettier setup
goeson00
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With
prettierwe will have consistent formatting of JS code of our test files.Motivation and Context
Consistent formatting.
Types of changes
Checklist:
I hereby agree to the terms of the Cogboard Contributor License Agreement.