Build scripts updated and refactored #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| url = uri("https://plugins.gradle.org/m2") | ||
| url = uri("http://dl.bintray.com/cognifide/maven-public") | ||
| url = uri("https://dl.bintray.com/neva-dev/maven-public") | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation("com.moowork.gradle:gradle-node-plugin:1.2.0") |
There was a problem hiding this comment.
Updating node causes a lot of problems... i left it un-updated
| } | ||
|
|
||
| dependencies { | ||
| implementation("com.moowork.gradle:gradle-node-plugin:1.2.0") | ||
| implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.31") | ||
| implementation("com.bmuschko:gradle-docker-plugin:4.10.0") | ||
| implementation("net.researchgate:gradle-release:2.6.0") |
There was a problem hiding this comment.
gradle-release No longer in use
| @@ -43,7 +43,7 @@ class BoardsAndWidgetsController : AbstractVerticle() { | |||
|
|
|||
| private fun prepareConfig() = mapOf<String, (JsonObject) -> String>( | |||
| "update" to { body -> update(body) }, | |||
| "get" to { body -> boardsConfigService.loadBoardsConfig().toString() } | |||
| "get" to { _ -> boardsConfigService.loadBoardsConfig().toString() } | |||
There was a problem hiding this comment.
Detekt fix
|
|
||
| tasks { |
There was a problem hiding this comment.
task registration is now grouped in { ... }
Comment on lines
-134
to
-137
| tasks.register<Exec>("copyCypressContent") { | ||
| group = "docker-functional-tests" | ||
| commandLine = listOf("sh", "scripts/copyCypressContent.sh", "$cypressContentPath", "$mountDir") | ||
| mustRunAfter("redeployLocal") |
There was a problem hiding this comment.
@staszke - We have better approach for copying files - lets use the old way without unnecessary script that will not work when you don't have shell sh installed on your system.
Comment on lines
+9
to
+13
| maven { | ||
| url = uri("https://plugins.gradle.org/m2") | ||
| url = uri("http://dl.bintray.com/cognifide/maven-public") | ||
| url = uri("https://dl.bintray.com/neva-dev/maven-public") | ||
| } |
There was a problem hiding this comment.
lets group them together
szymon-owczarzak
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an update and refactor - no functional changes.
I hereby agree to the terms of the Cogboard Contributor License Agreement.