AEM Bundle Info Widget - add docs, fix QA issues and spacing #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tMaxx
commented
Jan 7, 2020
tMaxx
commented
- Added option to filter by bundle's display name
- Fixed popover title attribute
- Changed styling to make widget fit in default grid when exclusions are set
- Added docs for configuration options
szymon-owczarzak
approved these changes
Jan 8, 2020
cogboard-app/src/main/kotlin/com/cognifide/cogboard/widget/type/AemBundleInfoWidget.kt
Outdated
Show resolved
Hide resolved
| @@ -98,7 +100,7 @@ class AemBundleInfoWidget(vertx: Vertx, config: JsonObject) : AsyncWidget(vertx, | |||
|
|
|||
| override fun updateState() { | |||
| if (url.isNotBlank()) { | |||
| httpGet("$url/system/console/bundles.json") | |||
| httpGet("${url.trimEnd('/')}/system/console/bundles.json") | |||
There was a problem hiding this comment.
I thing better solution for this would be to replace any double slash // to single slash / but inside httpGet() method - something like prepareURL method. What do you think?
There was a problem hiding this comment.
This turns out to be a bit trickier, so I'll roll it back. Parsing URLs is problematic, ideally we'd have to have some more helper functions to handle cases like this.
Southeaven
reviewed
Jan 8, 2020
cogboard-webapp/src/components/widgets/types/AemBundleInfoWidget/index.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.