-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One common UpdateHandler #158
Conversation
private fun listenOnBoardConfig() { | ||
factory.create(EVENT_BOARDS_CONFIG, vertx, prepareConfig()) | ||
} | ||
private fun prepareConfig() = mapOf<String, (JsonObject) -> String>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method spacing, newline please
@@ -1,14 +1,14 @@ | |||
{ | |||
"endpoints": [ | |||
{ | |||
"id": "api-mocks-endpoint", | |||
"id": "endpoint1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, explain this; we had a nice, descriptive name, and now we don't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because of method:
com.cognifide.cogboard.config.service.EndpointsService#generateId
For nice name we can always use labels
, right :)?
No description provided.