Changing conditional operators #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tMaxx
reviewed
Dec 11, 2019
| @@ -11,15 +11,15 @@ services: | |||
| jdk: | |||
| - oraclejdk11 | |||
| before_script: | |||
| - if [[ "$TRAVIS_BRANCH" = "master" && "$TRAVIS_EVENT_TYPE" = "push" ]]; then export | |||
| - if [[ "$TRAVIS_BRANCH" == "master" && "$TRAVIS_EVENT_TYPE" == "push" ]]; then export | |||
There was a problem hiding this comment.
Changing to double equals won't make any kind of difference, this is bash, not JS :P
There was a problem hiding this comment.
I guess you're right. I always thought that = and == work differently within [[ command, turns out it's the double quoting that makes things different. Although the essence of those changes is the 22nd line.
There was a problem hiding this comment.
There is a difference between them, but in this case it doesn't matter (i think it has to do with pattern matching).
tMaxx
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.